Make it possible to skip adding an Bindings.conf entry for the classes which are currently empty

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
3 months ago

People

(Reporter: Ehsan, Assigned: bzbarsky)

Tracking

({dev-doc-complete})

Trunk
mozilla18
x86
macOS
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

7 years ago
See bug 792646 comment 2.
* Consequential interfaces with no explicit descriptor are still skipped.
* If no information is provided about an interface, an empty descriptor is
  assumed.
* If a list is provided and the only entry is a worker descriptor, an empty
  main-thread descriptor is assumed.
Attachment #663441 - Flags: review?(peterv)
Reporter

Comment 2

7 years ago
This should be documented in Bindings.conf as well.
Once this lands, I should also update the docs on MDN.
Keywords: dev-doc-needed
Comment on attachment 663441 [details] [diff] [review]
Don't force consumers to list descriptors for interfaces that are using all teh defaults.   new setup is:

Review of attachment 663441 [details] [diff] [review]:
-----------------------------------------------------------------

Please add some documentation to Bindings.conf, especially about the worker stuff.

::: dom/bindings/Configuration.py
@@ +36,5 @@
> +                # because chances are we don't need to do anything interesting
> +                # with them.
> +                if iface.isConsequential():
> +                    continue
> +                else:

no need for the else
Attachment #663441 - Flags: review?(peterv) → review+
Made that change, and https://hg.mozilla.org/integration/mozilla-inbound/rev/86cc9c289960
Assignee: nobody → bzbarsky
Flags: in-testsuite-
Target Milestone: --- → mozilla18
Updated MDN.
https://hg.mozilla.org/mozilla-central/rev/86cc9c289960
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.