793036 - Close all service windows on logout.

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

All service windows (eg, chat windows) must be closed when the user logs out of the service (ie, when the provider tells is there is a 'null' profile)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Close all chat windows on logout

Also added a utility function haveLoggedInUser() which a couple other things reuse.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 663310 [details] [diff] [review]
Close all chat windows on logout

Review of attachment 663310 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +173,5 @@
>    // Whether the chats can be shown for this window.
>    get canShow() {
> +    if (!SocialUI.haveLoggedInUser()) {
> +      return false;
> +    }

No need for the curly brackets if it is a one-line if block.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/503de52e9c72

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/503de52e9c72

Should this have a test?

Comment 5

[Mark Hammond [:markh] [:mhammond]]

tests via bug 793935

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cbf2fd49f4ec

Comment 7

[u279076]

No QA verification since this has in-testsuite coverage. Please add verifyme keyword to request manual verification.