Close all service windows on logout.

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 18
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
All service windows (eg, chat windows) must be closed when the user logs out of the service (ie, when the provider tells is there is a 'null' profile)
(Assignee)

Comment 1

5 years ago
Created attachment 663310 [details] [diff] [review]
Close all chat windows on logout

Also added a utility function haveLoggedInUser() which a couple other things reuse.
Assignee: nobody → mhammond
Attachment #663310 - Flags: review?(jaws)
Comment on attachment 663310 [details] [diff] [review]
Close all chat windows on logout

Review of attachment 663310 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +173,5 @@
>    // Whether the chats can be shown for this window.
>    get canShow() {
> +    if (!SocialUI.haveLoggedInUser()) {
> +      return false;
> +    }

No need for the curly brackets if it is a one-line if block.
Attachment #663310 - Flags: review?(jaws) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/503de52e9c72
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/503de52e9c72

Should this have a test?
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
(Assignee)

Updated

5 years ago
Depends on: 793935
(Assignee)

Comment 5

5 years ago
tests via bug 793935
Flags: in-testsuite? → in-testsuite+
Attachment #663310 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/cbf2fd49f4ec
status-firefox17: --- → fixed
No QA verification since this has in-testsuite coverage. Please add verifyme keyword to request manual verification.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.