Closed Bug 793036 Opened 7 years ago Closed 7 years ago

Close all service windows on logout.

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(firefox17 fixed)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

All service windows (eg, chat windows) must be closed when the user logs out of the service (ie, when the provider tells is there is a 'null' profile)
Also added a utility function haveLoggedInUser() which a couple other things reuse.
Assignee: nobody → mhammond
Attachment #663310 - Flags: review?(jaws)
Comment on attachment 663310 [details] [diff] [review]
Close all chat windows on logout

Review of attachment 663310 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +173,5 @@
>    // Whether the chats can be shown for this window.
>    get canShow() {
> +    if (!SocialUI.haveLoggedInUser()) {
> +      return false;
> +    }

No need for the curly brackets if it is a one-line if block.
Attachment #663310 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/503de52e9c72

Should this have a test?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Depends on: 793935
tests via bug 793935
Flags: in-testsuite? → in-testsuite+
Attachment #663310 - Flags: approval-mozilla-aurora+
No QA verification since this has in-testsuite coverage. Please add verifyme keyword to request manual verification.
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.