bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

MMI Codes: get IMEI

RESOLVED FIXED in Firefox 18

Status

()

Core
DOM: Device Interfaces
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

Trunk
mozilla19
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [LOE:S])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
As per device certification requirements we need to support the *#06# MMI code to get the device IMEI code.
(Assignee)

Updated

6 years ago
Blocks: 793178
(Assignee)

Updated

6 years ago
blocking-basecamp: --- → ?
(Assignee)

Updated

6 years ago
Assignee: nobody → ferjmoreno
Is this a P1 blockers or is it a nice-to-have?
Whiteboard: [blocked-on-input philikon]
(In reply to Andrew Overholt [:overholt] from comment #1)
> Is this a P1 blockers or is it a nice-to-have?

Blocker because device certification requirement.
Whiteboard: [blocked-on-input philikon]
blocking-basecamp: ? → +
(Assignee)

Updated

6 years ago
Whiteboard: [LOE:S]
(Assignee)

Comment 3

6 years ago
I consider this task as LOE:S once bug 793186 lands.
Depends on: 793186
(Assignee)

Comment 4

6 years ago
Created attachment 669437 [details] [diff] [review]
Part 1: RIL

Not much to explain. This patch allows the retrieval of the device's IMEI via the *#06# MMI code.
Attachment #669437 - Flags: review?(marshall)
(Assignee)

Comment 5

6 years ago
Created attachment 669438 [details] [diff] [review]
Part 2: Test
Attachment #669438 - Flags: review?(marshall)
(Assignee)

Comment 6

6 years ago
Created attachment 669441 [details] [diff] [review]
Part 2: Test

Sorry for the spam Marshall, I didn't qref when added the 'error' test.
Attachment #669438 - Attachment is obsolete: true
Attachment #669438 - Flags: review?(marshall)
Attachment #669441 - Flags: review?(marshall)

Updated

6 years ago
Priority: -- → P1
Attachment #669437 - Flags: review?(marshall) → review+
Comment on attachment 669437 [details] [diff] [review]
Part 1: RIL

Review of attachment 669437 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! missed one comment..

::: dom/system/gonk/RILContentHelper.js
@@ +716,5 @@
>        case "RIL:SendMMI:Return:OK":
>        case "RIL:CancelMMI:Return:OK":
>          request = this.takeRequest(msg.json.requestId);
>          if (request) {
> +          Services.DOMRequest.fireSuccess(request, msg.json.result);

does this change the semantics for any of the other Send/CancelMMI results? (are we testing these DOM results anywhere?)
Comment on attachment 669441 [details] [diff] [review]
Part 2: Test

Review of attachment 669441 [details] [diff] [review]:
-----------------------------------------------------------------

It might be good to test the actual IMEI of the emulator at some point, but these tests are a good start. Maybe a file a follow up?
Attachment #669441 - Flags: review?(marshall) → review+
(Assignee)

Comment 9

6 years ago
Thanks for the review Marshall! :)

(In reply to Marshall Culpepper [:marshall_law] from comment #7)
> Comment on attachment 669437 [details] [diff] [review]
> Part 1: RIL
> 
> Review of attachment 669437 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good! missed one comment..
> 
> ::: dom/system/gonk/RILContentHelper.js
> @@ +716,5 @@
> >        case "RIL:SendMMI:Return:OK":
> >        case "RIL:CancelMMI:Return:OK":
> >          request = this.takeRequest(msg.json.requestId);
> >          if (request) {
> > +          Services.DOMRequest.fireSuccess(request, msg.json.result);
> 
> does this change the semantics for any of the other Send/CancelMMI results?
> (are we testing these DOM results anywhere?)

No, sending 'msg.json' instead of 'msg.json.result' was actually a bug.
And no, I am afraid that we are not testing these DOM results anywhere yet.

(In reply to Marshall Culpepper [:marshall_law] from comment #8)
> Comment on attachment 669441 [details] [diff] [review]
> Part 2: Test
> 
> Review of attachment 669441 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It might be good to test the actual IMEI of the emulator at some point, but
> these tests are a good start. Maybe a file a follow up?

Indeed, I have a patch ready with marionette tests (where we also check the DOMRequest.result), but I couldn't run it cause the emulator is not working for me :\. I'll file a follow-up bug for the marionette tests.
(Assignee)

Updated

6 years ago
Depends on: 802506

Comment 11

6 years ago
https://hg.mozilla.org/mozilla-central/rev/d8cf2a31d1b9
https://hg.mozilla.org/mozilla-central/rev/5bff19e795d6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
https://hg.mozilla.org/releases/mozilla-aurora/rev/ae52f5c31f5c
https://hg.mozilla.org/releases/mozilla-aurora/rev/8ab4d2cd6120
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Flags: in-testsuite+
Blocks: 819528
You need to log in before you can comment on or make changes to this bug.