793384 - Restrict version numbers to positive integers

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

For sync2.0, let's spec that version numbers are positive integers.  This will the kind of silliness found in Bug 793037, where negative integer timestamps are being encountered.

Comment 1

[Richard Newman [:rnewman]]

Actually, negative *floats*, right? :D

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: docs patch restricting various things to positive integers

Might as well restrict other related fields to positive integers while I'm here.  Richard, any complaints about the additional restrictions documented in this patch?

Comment 3

[Ryan Kelly [:rfkelly]]

Docs patch committed: https://github.com/mozilla-services/docs/commit/4ae535933783533a02373aa749b581afbd43ab57

I need to code up some tests for these changes, and likely some tweaks to the server code as well.

Comment 4

[Ryan Kelly [:rfkelly]]

Attachment: code patch restricting various things to positive integers

Minimal code patch to restrict various fields/args to positive integers.  As I migrate to cornice-format errors I will probably re-do the validation using cornice validators.

Comment 5

[Toby Elliott [:telliott]]

Comment on attachment 680933 [details] [diff] [review]
code patch restricting various things to positive integers

Gets a positive review, of course (though I had to go back to the original code to check the places where the change was just updating the comment!)

Comment 6

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-syncstorage/commit/367b792332e7120f912de027d44ce9bb754a1a38