Closed Bug 793523 Opened 7 years ago Closed 7 years ago

Bookmarks Search doesn't work on big endian after 64-bit folder ID change

Categories

(Toolkit :: Places, defect)

PowerPC
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
Tracking Status
firefox15 --- wontfix
firefox16 --- wontfix
firefox17 --- fixed

People

(Reporter: spectre, Assigned: spectre)

References

()

Details

Attachments

(1 file)

"TenFourFox: I Like Big Endian and I Cannot Lie"

Upstreamed from http://code.google.com/p/tenfourfox/issues/detail?id=177

After bug 702639, bookmarks search stopped working on big endian, including TenFourFox and derivatives on PowerPC. NSPR logging showed that the parent IDs were all appearing as zero in the generated SQL. This is probably an endian issue since the same code worked when they were 32-bit. Simply changing the %d to %lld in the attached patch should suffice for this instance, although there are probably others.
Attachment #663847 - Flags: review?
Attachment #663847 - Flags: review? → review?(mak77)
Comment on attachment 663847 [details] [diff] [review]
Use %lld when nsPrintfCString'ing the parent ID

Review of attachment 663847 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, this was indeed wrong :(
If you need help pushing this just let me know.
Attachment #663847 - Flags: review?(mak77) → review+
I don't have checkin or try permissions -- does this need a try run? Otherwise, yes, please. Thank you!
Status: NEW → ASSIGNED
Comment on attachment 663847 [details] [diff] [review]
Use %lld when nsPrintfCString'ing the parent ID

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 702639
User impact if declined: bookmarks not working properly on big-endian platforms
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Trivial change, no risk
String or UUID changes made by this patch: none

note: while this doesn't meet usual approval regarding priority, it's so trivial and risk free I think may be worth to get it earlier.
Attachment #663847 - Flags: approval-mozilla-aurora?
Attachment #663847 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7026b17114f9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.