793578 - Certain game benchmark would not start by clicking START

Status: VERIFIED WORKSFORME

(Tech Evangelism Graveyard :: English US, defect)

Description

[Alice0775 White]

http://hg.mozilla.org/mozilla-central/rev/9d285bedbc1f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120923030601

Steps to reproduce:
  1. Open http://www.4gamer.net/specials/enchant/bench/
  2. Click "START"

Actual results:
  The game do not start
   
Expected results:
  The game should start

Regression window(m-c)
Good(except Bug 793132)
http://hg.mozilla.org/mozilla-central/rev/b461a7cd250e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922052915
Bad:
http://hg.mozilla.org/mozilla-central/rev/9d285bedbc1f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922154714
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b461a7cd250e&tochange=9d285bedbc1f


Regression window(m-i)
Good(except Bug 793132)
http://hg.mozilla.org/integration/mozilla-inbound/rev/8d077e0638d4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922122715
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/fcf9991c8d97
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120922122915
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8d077e0638d4&tochange=fcf9991c8d97
Suspected : Bug 726615

Comment 1

[Alex Keybl [:akeybl]]

Starting this bug with you jimm - please re-assign as you see fit.

Comment 2

[Jim Mathies [:jimm]]

General discussion has taken place in bug 794066 and bug 794711.

Comment 3

[Jim Mathies [:jimm]]

Attachment: jstest

Comment 4

[Jim Mathies [:jimm]]

Interesting, Chrome works with this demo on desktops that do not support touch. On a win8 tablet with touch input they have the same problem we do. So basically chrome has decided to hide touch handlers on systems that don't support touch input. Personally I think this is bad behavior. Sites shouldn't use the existence of touchstart to test for touch input devices. (Just like they shouldn't use mousedown to test for the existence of a physical mouse.)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Jim Mathies [:jimm] from comment #4)
> Sites
> shouldn't use the existence of touchstart to test for touch input devices.

But that is one way how sites have tested the existence of touch input for years.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Olli Pettay [:smaug] from comment #5)
> (In reply to Jim Mathies [:jimm] from comment #4)
> > Sites
> > shouldn't use the existence of touchstart to test for touch input devices.
> 
> But that is one way how sites have tested the existence of touch input for
> years.

Ok, but with new devices that support both, this method is flawed anyway. Should we try to ween people off of this flawed approach and instead use something else like a media query?

Comment 7

[Makoto Kato [:m_kato]]

enchant.js issue.  I report this to them as https://github.com/wise9/enchant.js/issues/102

Comment 8

[Masatoshi Kimura [:emk]]

(In reply to Jim Mathies [:jimm] from comment #6)
> Ok, but with new devices that support both, this method is flawed anyway.
> Should we try to ween people off of this flawed approach and instead use
> something else like a media query?
This is not a problem of the test method. It's fine to install a touch event handler when it is supported. The problem is, sites do NOT install a mouse event handler if touch is supported.
This may be the reason MS introduced a completely new, integrated DOM pointer events which will be fired regardless of the device type.

Comment 9

[Adam Stevenson [:adamopenweb]]

This works for me in FF29 on osx. About half the frame rate of Chrome but no error as stated in the STR. I'm going to close this bug but please reopen if the issue still exists.

Comment 10

[Alice0775 White]

I can verify.
It works in Firefox24.5.0 and Firefox29.0