793906 - disable desktop support while we get B2G going.

Status: RESOLVED FIXED

(Core Graveyard :: Identity, enhancement)

Description

[Ben Adida [:benadida]]

Some tweaks for B2G will surely bust the desktop builds, so let's disable it for anything other than B2G.

Comment 1

[Matthew N. [:MattN] (PM me if requests are blocking you)]

It's disabled by default so I guess disabling the tests would be the main thing.
If we really need to disable the desktop UI, commenting out the bodies of SignInToWebsiteUX_init and SignInToWebsiteUX_uninit should cover most, if not all, of it.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks also, Matt, for the additional suggestion you made on irc that we should comment this out:

https://mxr.mozilla.org/mozilla-central/source/browser/modules/test/Makefile.in#17

I like this approach.  Very easy to switch things back on again.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: suppress native identity on desktop

Try: https://tbpl.mozilla.org/?tree=Try&rev=27b35bb75c0c

Comment 4

[Ben Adida [:benadida]]

Comment on attachment 665646 [details] [diff] [review]
suppress native identity on desktop

Review of attachment 665646 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f552864888a

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0f552864888a

Comment 7

[John Morrison [:jrgm]]

navigator.id is not disabled in 19.0a1 (2012-10-31) on OSX when pref 
dom.identity.enabled is true.

Comment 8

[Matthew N. [:MattN] (PM me if requests are blocking you)]

The DOM code will run but the UI should be disabled. The pref is for the DOM code. Is that not what you're seeing? Is this a problem?

Comment 9

[John Morrison [:jrgm]]

Hmm, so, yes, the native navigator.id is available, but the UI is disabled. 
I really think native navigator.id should not be available though.

Comment 10

[Matthew N. [:MattN] (PM me if requests are blocking you)]

Well, it's not available by default.  The user would have to flip the pref to use it and we haven't widely told people to do so.

Comment 11

[Ben Adida [:benadida]]

John: I think this is sufficiently disabled as far as I meant it when I opened the bug originally. I'm hoping you're okay with me re-closing it :)