Last Comment Bug 793906 - disable desktop support while we get B2G going.
: disable desktop support while we get B2G going.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Identity (show other bugs)
: unspecified
: All All
-- enhancement (vote)
: mozilla18
Assigned To: Jed Parsons (use needinfo, please) [:jedp, :jparsons]
:
: Fernando Jiménez Moreno [:ferjm]
Mentors:
Depends on: 928579
Blocks: basecamp-id
  Show dependency treegraph
 
Reported: 2012-09-24 16:56 PDT by Ben Adida [:benadida]
Modified: 2013-10-18 16:44 PDT (History)
7 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
suppress native identity on desktop (2.42 KB, patch)
2012-09-27 14:19 PDT, Jed Parsons (use needinfo, please) [:jedp, :jparsons]
benadida: review+
Details | Diff | Splinter Review

Description User image Ben Adida [:benadida] 2012-09-24 16:56:45 PDT
Some tweaks for B2G will surely bust the desktop builds, so let's disable it for anything other than B2G.
Comment 1 User image Matthew N. [:MattN] (PM if requests are blocking you) 2012-09-24 17:11:25 PDT
It's disabled by default so I guess disabling the tests would be the main thing.
If we really need to disable the desktop UI, commenting out the bodies of SignInToWebsiteUX_init and SignInToWebsiteUX_uninit should cover most, if not all, of it.
Comment 2 User image Jed Parsons (use needinfo, please) [:jedp, :jparsons] 2012-09-25 16:59:28 PDT
Thanks also, Matt, for the additional suggestion you made on irc that we should comment this out:

https://mxr.mozilla.org/mozilla-central/source/browser/modules/test/Makefile.in#17

I like this approach.  Very easy to switch things back on again.
Comment 3 User image Jed Parsons (use needinfo, please) [:jedp, :jparsons] 2012-09-27 14:19:50 PDT
Created attachment 665646 [details] [diff] [review]
suppress native identity on desktop

Try: https://tbpl.mozilla.org/?tree=Try&rev=27b35bb75c0c
Comment 4 User image Ben Adida [:benadida] 2012-09-27 14:34:37 PDT
Comment on attachment 665646 [details] [diff] [review]
suppress native identity on desktop

Review of attachment 665646 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2012-09-27 20:29:46 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f552864888a
Comment 6 User image Ed Morley [:emorley] 2012-09-28 07:52:57 PDT
https://hg.mozilla.org/mozilla-central/rev/0f552864888a
Comment 7 User image John Morrison [:jrgm] 2012-10-31 15:48:44 PDT
navigator.id is not disabled in 19.0a1 (2012-10-31) on OSX when pref 
dom.identity.enabled is true.
Comment 8 User image Matthew N. [:MattN] (PM if requests are blocking you) 2012-10-31 15:55:30 PDT
The DOM code will run but the UI should be disabled. The pref is for the DOM code. Is that not what you're seeing? Is this a problem?
Comment 9 User image John Morrison [:jrgm] 2012-10-31 17:06:06 PDT
Hmm, so, yes, the native navigator.id is available, but the UI is disabled. 
I really think native navigator.id should not be available though.
Comment 10 User image Matthew N. [:MattN] (PM if requests are blocking you) 2012-10-31 17:42:21 PDT
Well, it's not available by default.  The user would have to flip the pref to use it and we haven't widely told people to do so.
Comment 11 User image Ben Adida [:benadida] 2012-11-02 10:28:50 PDT
John: I think this is sufficiently disabled as far as I meant it when I opened the bug originally. I'm hoping you're okay with me re-closing it :)

Note You need to log in before you can comment on or make changes to this bug.