Want F5 to view/reload as per browser

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
MailNews: Message Display
--
enhancement
RESOLVED FIXED
17 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

17 years ago
This is Win32-specific.

Browser windows reload/refresh when you press F5.
Mail windows don't.
This would apply to messenger, message window and alternate layout window.

Comment 1

17 years ago
Refresh the 3-pane? Exactly what is it that you want to refresh? Do you want the
biff to check for new email?

Please elaborate and make a more specific summary.  Thanks.
(Reporter)

Comment 2

17 years ago
I would like to see F5 to duplicate View/Reload as it does in a navigator window.
Summary: Want F5 to reload as per browser → Want F5 to view/reload as per browser

Comment 3

16 years ago
Reporter: what is it that you want F5 to do ? the description is a little unclear.

I was about to file a bug for this, but this bug (by the title) sounds like what
I want:
Request to wire up F5 to perform "get new mail"
(probably just for the current account opened in the case of multiple mail accounts)

Not a tricky one I'm sure.
(Reporter)

Comment 4

16 years ago
Peter, I'm not sure how else to describe the Reload option in the View menu,
but it's not what you were looking for.

Compare with a browser window which (on Windows) allows F5 to reload the page.

Comment 5

16 years ago
Ok, in a browser window, a reload means you reload the content from the website.

What do you want reloaded when you press F5 when viewing mail ?
the message ?
the message list/threadpane ?
the folder list ?

Updated

16 years ago
Severity: trivial → enhancement
(Reporter)

Comment 6

16 years ago
It was the message that I was interested in, I think that's what View/Reload does.

Comment 7

16 years ago
See also bug 129823, F5 in mail should get new mail.
Product: Browser → Seamonkey

Updated

13 years ago
Assignee: sspitzer → mail

Comment 8

12 years ago
This is a problem in Thunderbird 1.5 too.

I have a program which continually gets new messages and appends them to folders (or creates a new folder if the destination doesn't already exist).  But the new messages don't show up in Thunderbird when I go to a folder unless I either press F5 (there is no "refresh" action listed in the pull-down or right-click menues) or exit and restart Thunderbird.  And even that doesn't work if Thunderbird has touched the folder's *.msf file (such as during search or compaction).  In that case I have to exit, 'touch' the mail folder, and restart Thunderbird to see the new messages listed in the message-list frame.

To do:  F5 in the message-list frame is probably OK as-is for most users, but "refresh messages" should be added to a menu somewhere.  Shift-F5 should re-read the current folder and make a new *.msf file.  F5 in the folder-tree frame should refresh the list of folders. 
Assignee: mail → nobody
QA Contact: esther → message-display

Comment 9

8 years ago
bug 129823 is competing with this one for the F5 key in mail, we need to decide which one to WONTFIX before we fix one of them. Thunderbird went with hooking it up to "Get New Messages", by the way.
(Assignee)

Comment 10

8 years ago
In bug 512169 we bound the Reload key on media keyboards to View/Reload, both in the browser and MailNews. I think it's only consistent to do the same for F5, especially since in case of news feeds we often display a web site in MailNews, too.

(In reply to comment #9)
> bug 129823 is competing with this one for the F5 key in mail, we need to decide
> which one to WONTFIX before we fix one of them.

If we all agree what F5 should do in MailNews we can may dupe this one to yours (which has a broader scope).

> Thunderbird went with hooking it up to "Get New Messages", by the way.

No need to repeat mistakes. ,-)

Comment 11

8 years ago
> If we all agree what F5 should do in MailNews we can may dupe this one to yours
> (which has a broader scope).

I WONTFIXed bug 129823 for a reason...

> > Thunderbird went with hooking it up to "Get New Messages", by the way.
> 
> No need to repeat mistakes. ,-)

Exactly.
OS: Windows 95 → All
Hardware: x86 → All
Whiteboard: [good first bug]
(Assignee)

Comment 12

7 years ago
Created attachment 487715 [details] [diff] [review]
make F5 Reload

Cf. bug 509954 to make F5 Reload cross-platform in the browser as well.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #487715 - Flags: superreview?(neil)
Attachment #487715 - Flags: review?(mnyromyr)
(Assignee)

Comment 13

7 years ago
Comment on attachment 487715 [details] [diff] [review]
make F5 Reload

Stefan, given your comment on bug 509954, is this here OK from a Mac POV? Mind you, Accel+R is Reply in MailNews (on all platforms).
Attachment #487715 - Flags: review?(stefanh)

Comment 14

7 years ago
Comment on attachment 487715 [details] [diff] [review]
make F5 Reload

Sorry, no it's not - on Mac the F keys are reserved for the system. Basically, you should never assign a F key to something.
Attachment #487715 - Flags: review?(stefanh) → review-

Comment 15

7 years ago
(In reply to comment #13)
> Mind you, Accel+R is Reply in MailNews (on all platforms).

That's unfortunate - we should probably change that on mac if we want consistency with the browser.
(Assignee)

Comment 16

7 years ago
(In reply to comment #14)
> Comment on attachment 487715 [details] [diff] [review]
> make F5 Reload
> 
> Sorry, no it's not - on Mac the F keys are reserved for the system. Basically,
> you should never assign a F key to something.

Umm, I don't have a Mac, but according to the MailNews Shortcuts Help page, F6 and F8 are assigned on Mac as well. Which shortcuts does the View/Layout sub-menu show for you?

I'd really love to not have to make a Mac exception here, but if required I guess I'd have to introduce some platform files since preprocessing is so frowned upon in SM land...

(In reply to comment #15)
> (In reply to comment #13)
> > Mind you, Accel+R is Reply in MailNews (on all platforms).
> 
> That's unfortunate - we should probably change that on mac if we want
> consistency with the browser.

If you suggest that Accel+R should be Reload in MailNews... Well, ultimately you'd have to discuss that with Karsten (and probably in another bug), but it feels strange to me. Again, I don't have a Mac.

Comment 17

7 years ago
(In reply to comment #16)
> (In reply to comment #14)
> > Comment on attachment 487715 [details] [diff] [review] [details]
> > make F5 Reload
> > 
> > Sorry, no it's not - on Mac the F keys are reserved for the system. Basically,
> > you should never assign a F key to something.
> 
> Umm, I don't have a Mac, but according to the MailNews Shortcuts Help page, F6
> and F8 are assigned on Mac as well. Which shortcuts does the View/Layout
> sub-menu show for you?

(F keys are not shown in the menus). According to Apple, F8 is used for "Tile or untile all enabled spaces". They're actually assigned, but it's really wrong to have these keys assigned for mac and continuing adding the wrong keys are... well, not the best way to solve the problem ;-)

They key thing is that Apple currently uses F8-F12 for different tasks and then uses F5-F7 in combination with other keys (http://developer.apple.com/library/mac/#documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGKeyboardShortcuts/XHIGKeyboardShortcuts.html#//apple_ref/doc/uid/TP40002725-CHDIGFBH). You also don't know when they start using them for other purposes, so adding F5 is not a very good idea (besides, no-one would use it since you don't expect it to work, it's an unknown app shortcut key for mac users).

> I'd really love to not have to make a Mac exception here

Actually, that's the problem. In the old days, nobody made any exceptions, so now we're stuck with some really odd shortcut keys on Mac (best example is F9 which stopped working 2004, because the OS started using it).

> 
> (In reply to comment #15)
> > (In reply to comment #13)
> > > Mind you, Accel+R is Reply in MailNews (on all platforms).
> > 
> > That's unfortunate - we should probably change that on mac if we want
> > consistency with the browser.
> 
> If you suggest that Accel+R should be Reload in MailNews... Well, ultimately
> you'd have to discuss that with Karsten (and probably in another bug), but it
> feels strange to me. Again, I don't have a Mac.

I actually don't know what to do about it. Maybe we will have to live with the inconsistency and get a new mac shortcut for mailNews reload.

Comment 18

7 years ago
(In reply to comment #16) 

> I'd really love to not have to make a Mac exception here, but if required I
> guess I'd have to introduce some platform files since preprocessing is so
> frowned upon in SM land...

platformMailnewsOverlay.xul should work, no?
(Assignee)

Comment 19

7 years ago
Created attachment 487889 [details] [diff] [review]
make F5 Reload v2

(In reply to comment #18)
> platformMailnewsOverlay.xul should work, no?

Oops, should have checked that, thanks!

It seems F5 now only works after you have opened the View menu once. I guess that's because of the disabled attribute on the command?
Attachment #487715 - Attachment is obsolete: true
Attachment #487715 - Flags: superreview?(neil)
Attachment #487715 - Flags: review?(mnyromyr)
Attachment #487889 - Flags: superreview?(neil)
Attachment #487889 - Flags: review?(mnyromyr)
Attachment #487889 - Flags: feedback?(stefanh)
(Reporter)

Comment 20

7 years ago
You can work around that by making the key call ReloadMessage directly.
(ReloadMessage does nothing if there is no reloadable message loaded.)
(Assignee)

Comment 21

7 years ago
Created attachment 487902 [details] [diff] [review]
make F5 Reload v2a [Checkin: comment 22]

(In reply to comment #20)
> You can work around that by making the key call ReloadMessage directly.
> (ReloadMessage does nothing if there is no reloadable message loaded.)

Thanks!
Attachment #487889 - Attachment is obsolete: true
Attachment #487889 - Flags: superreview?(neil)
Attachment #487889 - Flags: review?(mnyromyr)
Attachment #487889 - Flags: feedback?(stefanh)
Attachment #487902 - Flags: superreview?(neil)
Attachment #487902 - Flags: review?(mnyromyr)
Attachment #487902 - Flags: feedback?(stefanh)

Updated

7 years ago
Attachment #487902 - Flags: feedback?(stefanh) → feedback+
(Reporter)

Updated

7 years ago
Attachment #487902 - Flags: superreview?(neil) → superreview+

Updated

7 years ago
Attachment #487902 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 22

7 years ago
Comment on attachment 487902 [details] [diff] [review]
make F5 Reload v2a [Checkin: comment 22]

http://hg.mozilla.org/comm-central/rev/6da511123e92
Attachment #487902 - Attachment description: make F5 Reload v2a → make F5 Reload v2a [Checkin: comment 22]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → seamonkey2.1b2
You need to log in before you can comment on or make changes to this bug.