Closed
Bug 794206
Opened 12 years ago
Closed 11 years ago
Enabling the profiler hits JS_ASSERT(installed());
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
People
(Reporter: dhylands, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
534 bytes,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
I tried building from Mozilla-Inbound and when I run b2g with MOZ_PROFILER_STARTUP=1 then I hit the assert at: js/src/vm/SPSProfiler.cpp:58 Backtrace: #0 js::SPSProfiler::enable (this=0xa5a5b025, enabled=true) at /home/work/mozilla-inbound/js/src/vm/SPSProfiler.cpp:58 #1 0x418715b0 in js::EnableRuntimeProfilingStack (rt=<value optimized out>, enabled=true) at /home/work/mozilla-inbound/js/src/jsfriendapi.cpp:900 #2 0x4133ae28 in ProfileStack::enableJSSampling (aProfileEntries=<value optimized out>, aInterval=<value optimized out>, aFeatures=<value optimized out>, aFeatureCount=1) at /home/work/mozilla-inbound/tools/profiler/sps_sampler.h:351 #3 mozilla_sampler_start (aProfileEntries=<value optimized out>, aInterval=<value optimized out>, aFeatures=<value optimized out>, aFeatureCount=1) at /home/work/mozilla-inbound/tools/profiler/TableTicker.cpp:1100 #4 0x4133af7a in mozilla_sampler_init () at /home/work/mozilla-inbound/tools/profiler/TableTicker.cpp:1012 #5 0x4082f1c8 in XREMain::XRE_main (this=0xa5a5b025, argc=1, argv=0x3, aAppData=0x1) at /home/work/mozilla-inbound/toolkit/xre/nsAppRunner.cpp:3798 #6 0x4082f52a in XRE_main (argc=1, argv=0xbebaebb4, aAppData=0xb1c0, aFlags=<value optimized out>) at /home/work/mozilla-inbound/toolkit/xre/nsAppRunner.cpp:3923 #7 0x00008af4 in do_main (argc=1, argv=0xbebaebb4) at /home/work/mozilla-inbound/b2g/app/nsBrowserApp.cpp:153 #8 main (argc=1, argv=0xbebaebb4) at /home/work/mozilla-inbound/b2g/app/nsBrowserApp.cpp:229 From what I can gather, SPSProfiler::setProfilingStack or SetRuntimeProfilingStack needs to be called. I couldn't find any calls to either of these functions outside of the ones in js/src/jsapi-tests/testProfileStrings.cpp, or a call to EnableSPSProfilingAssertions (or the JS enableSPSProfilingAssertions)
Reporter | ||
Comment 1•12 years ago
|
||
I should mention that I hit the assert when using a DEBUG build. Everything seems to work fine with a non-DEBUG build, which suggests that the ASSERT may be superfluous.
Comment 2•12 years ago
|
||
We shouldn't be calling js::EnableRuntimeProfilingStack this early on startup. We need to wait until the JS engine is ready and has given us a context. See: http://mxr.mozilla.org/mozilla-central/source/tools/profiler/sps_sampler.h#349 I think we just forgot to init mRuntime to null. I'm surprised this hasn't come up in fennec before.
Comment 3•12 years ago
|
||
I'm traveling and don't have access to b2g hardware. Can you test this patch for me?
Reporter | ||
Comment 4•12 years ago
|
||
I removed the errant semi-colon from the patch, and it still asserts in the exact same place.
Comment 5•12 years ago
|
||
Alright well I think we want this patch anyways so let's land it but keep going with this bug.
Comment 6•12 years ago
|
||
Comment on attachment 664855 [details] [diff] [review] patch Ignore the extra ';'
Attachment #664855 -
Flags: review?(ehsan)
Updated•12 years ago
|
Attachment #664855 -
Flags: review?(ehsan) → review+
Comment 7•12 years ago
|
||
Carry forward r+
Attachment #664855 -
Attachment is obsolete: true
Attachment #666595 -
Flags: review+
Updated•12 years ago
|
Whiteboard: [leave open]
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/85f3e07f71ce
Flags: in-testsuite-
Reporter | ||
Comment 10•12 years ago
|
||
I thought I'd mention that I'm not seeing the assert any more. I think it's possible I applied the patch in a source tree different from the one I was building - Sigh.
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Whiteboard: [leave open]
You need to log in
before you can comment on or make changes to this bug.
Description
•