758697 - [Meta] Improve B2G support to the built-in profiler

Status: RESOLVED WONTFIX

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

We now support Desktop+Fennec. It should be simple now to add support for B2G.

Work needed:
1) How to control it. (signals, ADB, debug server)
2) How to get the symbols (from the phone if we continue to not strip them)
3) Updating the profiling extension to handle the above:
https://github.com/bgirard/Gecko-Profiler-Addon

Here's some info on the profiler if you haven't seen it already:
https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler

Comment 1

[Benoit Girard (:BenWa)]

I wanted to ask you today if you'd be interested in picking this up. I'll bug you tomorrow and give you more details. There isn't much work needed and can probably walk you through most of it.

Comment 2

[Benoit Girard (:BenWa)]

Profiling Add-on update to support B2G:
https://github.com/bgirard/Gecko-Profiler-Addon/compare/e2d285ec29...6ab7f01778

Currently the phone must have an sdcard, patch coming up to save to /data/data if there's no sdcard.

Comment 3

[Benoit Girard (:BenWa)]

Sample profile of Crystal Skull:
http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv94POm7tgaRQAsmvQ0UmD6iEC8BJv2EngqoZ1SSZBdl2oLo4k3bxYutmlQwu6w02iMhw0wJqZPM5Gis_hrdtGRlYpUf-CvzbQ60w_ifxkETc5KblaG2RAJUzNUsniqv2qM1qD5w9k4PQ-2U2Wl4eTAIQNAqjNA

We're waiting on the glFinish

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Note, there's no difference between b2g and android there --- b2g phones will almost always have /sdcard, just like android, but on phones with removeable SD cards, /sdcard may temporarily be absent.  So we should do the same thing on both platforms.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Write to /data/local (Must be landed with addon change)

Ideally we would fall back to others (/data/data, /sdcard) but I rather just do it the right way and switch to using debug TCP sockets since it will let us start/stop/inspect.

Comment 6

[Benoit Girard (:BenWa)]

Reminder: Update https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler#Availability when this lands.

Comment 7

[Benoit Girard (:BenWa)]

The B2G profiler can work on b2g now but still doesn't support multi-process properly. Morphing this into a tracking bug on work to better support B2G (and multi-thread/multi-process gecko)

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 633860 [details] [diff] [review]
Write to /data/local (Must be landed with addon change)

This patch is made obsolete by refactoring of the saving code done by glandium.

Comment 9

[Benoit Girard (:BenWa)]

Turning this into a proper tracker bug.