Last Comment Bug 758697 - [Meta] Improve B2G support to the built-in profiler
: [Meta] Improve B2G support to the built-in profiler
Status: ASSIGNED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on: 836590 840313 848071 861863 779291 789667 792855 794206 795910 797621 797627 797639 853363 867721 867728 867738 873914 873915 914654 1005204
Blocks: 827846
  Show dependency treegraph
 
Reported: 2012-05-25 10:59 PDT by Benoit Girard (:BenWa)
Modified: 2014-07-01 01:17 PDT (History)
16 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Write to /data/local (Must be landed with addon change) (611 bytes, patch)
2012-06-16 18:53 PDT, Benoit Girard (:BenWa)
no flags Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2012-05-25 10:59:51 PDT
We now support Desktop+Fennec. It should be simple now to add support for B2G.

Work needed:
1) How to control it. (signals, ADB, debug server)
2) How to get the symbols (from the phone if we continue to not strip them)
3) Updating the profiling extension to handle the above:
https://github.com/bgirard/Gecko-Profiler-Addon

Here's some info on the profiler if you haven't seen it already:
https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler
Comment 1 Benoit Girard (:BenWa) 2012-06-04 17:10:36 PDT
I wanted to ask you today if you'd be interested in picking this up. I'll bug you tomorrow and give you more details. There isn't much work needed and can probably walk you through most of it.
Comment 2 Benoit Girard (:BenWa) 2012-06-16 17:21:19 PDT
Profiling Add-on update to support B2G:
https://github.com/bgirard/Gecko-Profiler-Addon/compare/e2d285ec29...6ab7f01778

Currently the phone must have an sdcard, patch coming up to save to /data/data if there's no sdcard.
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-06-16 17:27:38 PDT
Note, there's no difference between b2g and android there --- b2g phones will almost always have /sdcard, just like android, but on phones with removeable SD cards, /sdcard may temporarily be absent.  So we should do the same thing on both platforms.
Comment 5 Benoit Girard (:BenWa) 2012-06-16 18:53:37 PDT
Created attachment 633860 [details] [diff] [review]
Write to /data/local (Must be landed with addon change)

Ideally we would fall back to others (/data/data, /sdcard) but I rather just do it the right way and switch to using debug TCP sockets since it will let us start/stop/inspect.
Comment 6 Benoit Girard (:BenWa) 2012-06-26 10:19:05 PDT
Reminder: Update https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler#Availability when this lands.
Comment 7 Benoit Girard (:BenWa) 2012-07-30 22:49:53 PDT
The B2G profiler can work on b2g now but still doesn't support multi-process properly. Morphing this into a tracking bug on work to better support B2G (and multi-thread/multi-process gecko)
Comment 8 Benoit Girard (:BenWa) 2012-07-30 22:50:23 PDT
Comment on attachment 633860 [details] [diff] [review]
Write to /data/local (Must be landed with addon change)

This patch is made obsolete by refactoring of the saving code done by glandium.
Comment 9 Benoit Girard (:BenWa) 2012-10-01 07:34:32 PDT
Turning this into a proper tracker bug.

Note You need to log in before you can comment on or make changes to this bug.