[Meta] Improve B2G support to the built-in profiler

RESOLVED WONTFIX

Status

()

Core
Gecko Profiler
RESOLVED WONTFIX
5 years ago
4 months ago

People

(Reporter: BenWa, Unassigned)

Tracking

(Depends on: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

5 years ago
We now support Desktop+Fennec. It should be simple now to add support for B2G.

Work needed:
1) How to control it. (signals, ADB, debug server)
2) How to get the symbols (from the phone if we continue to not strip them)
3) Updating the profiling extension to handle the above:
https://github.com/bgirard/Gecko-Profiler-Addon

Here's some info on the profiler if you haven't seen it already:
https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler
(Reporter)

Comment 1

5 years ago
I wanted to ask you today if you'd be interested in picking this up. I'll bug you tomorrow and give you more details. There isn't much work needed and can probably walk you through most of it.
Assignee: nobody → cbrocious
(Reporter)

Comment 2

5 years ago
Profiling Add-on update to support B2G:
https://github.com/bgirard/Gecko-Profiler-Addon/compare/e2d285ec29...6ab7f01778

Currently the phone must have an sdcard, patch coming up to save to /data/data if there's no sdcard.
Assignee: cbrocious → bgirard
Status: NEW → ASSIGNED
(Reporter)

Comment 3

5 years ago
Sample profile of Crystal Skull:
http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv94POm7tgaRQAsmvQ0UmD6iEC8BJv2EngqoZ1SSZBdl2oLo4k3bxYutmlQwu6w02iMhw0wJqZPM5Gis_hrdtGRlYpUf-CvzbQ60w_ifxkETc5KblaG2RAJUzNUsniqv2qM1qD5w9k4PQ-2U2Wl4eTAIQNAqjNA

We're waiting on the glFinish
Note, there's no difference between b2g and android there --- b2g phones will almost always have /sdcard, just like android, but on phones with removeable SD cards, /sdcard may temporarily be absent.  So we should do the same thing on both platforms.
(Reporter)

Comment 5

5 years ago
Created attachment 633860 [details] [diff] [review]
Write to /data/local (Must be landed with addon change)

Ideally we would fall back to others (/data/data, /sdcard) but I rather just do it the right way and switch to using debug TCP sockets since it will let us start/stop/inspect.
Attachment #633860 - Flags: review?(cbrocious)
(Reporter)

Comment 6

5 years ago
Reminder: Update https://developer.mozilla.org/en/Performance/Profiling_with_the_Built-in_Profiler#Availability when this lands.
(Reporter)

Comment 7

5 years ago
The B2G profiler can work on b2g now but still doesn't support multi-process properly. Morphing this into a tracking bug on work to better support B2G (and multi-thread/multi-process gecko)
Summary: Add B2G support to the built-in profiler → [Meta] Improve B2G support to the built-in profiler
(Reporter)

Comment 8

5 years ago
Comment on attachment 633860 [details] [diff] [review]
Write to /data/local (Must be landed with addon change)

This patch is made obsolete by refactoring of the saving code done by glandium.
Attachment #633860 - Attachment is obsolete: true
Attachment #633860 - Flags: review?(cbrocious)
(Reporter)

Comment 9

5 years ago
Turning this into a proper tracker bug.
Depends on: 794206, 792855, 789667
(Reporter)

Updated

5 years ago
Depends on: 795907
(Reporter)

Updated

5 years ago
Depends on: 795910
(Reporter)

Updated

5 years ago
Depends on: 797621
(Reporter)

Updated

5 years ago
Depends on: 797627
(Reporter)

Updated

5 years ago
No longer depends on: 795907
(Reporter)

Updated

5 years ago
Depends on: 779291
Depends on: 797639
(Reporter)

Updated

4 years ago
Depends on: 840313
(Reporter)

Updated

4 years ago
Assignee: bgirard → nobody
(Reporter)

Updated

4 years ago
Depends on: 853363
(Reporter)

Updated

4 years ago
Depends on: 836590
(Reporter)

Updated

4 years ago
Depends on: 861863
(Reporter)

Updated

4 years ago
Depends on: 848071
(Reporter)

Updated

4 years ago
Depends on: 867721
(Reporter)

Updated

4 years ago
Depends on: 867728
(Reporter)

Updated

4 years ago
Depends on: 867738
(Reporter)

Updated

4 years ago
Depends on: 873914
(Reporter)

Updated

4 years ago
Depends on: 873915
(Reporter)

Updated

4 years ago
Blocks: 827846

Updated

4 years ago
Keywords: perf
Whiteboard: c=profiling

Updated

4 years ago
Keywords: perf
Whiteboard: c=profiling
(Reporter)

Updated

4 years ago
Depends on: 914654
(Reporter)

Updated

3 years ago
Depends on: 1005204
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.