794349 - [b2g-bluetooth] Send correct +CIND: value to HS at SLC establishment

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

+CIND: is used by AG for telling HS current call status during the period of SLC establishment. In bug 792002, we sent fixed +CIND values to remote HS to let SLC be created successfully, but it still needs to be revised.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 669395 [details] [diff] [review]
v1 patch

Review of attachment 669395 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +426,5 @@
> +    if (!AppendIntegerToString(cind, mCall) ||
> +        !AppendIntegerToString(cind, mCallSetup) ||
> +        !AppendIntegerToString(cind, mCallHeld)) {
> +      NS_WARNING("Failed to convert mCall/mCallSetup/mCallHeld to string");
> +    }    

Supernit: extra whitespace

@@ +615,5 @@
> +   *            - 2: an outgoing call set up is ongoing
> +   *            - 3: remote party being alerted in an outgoing call
> +   * mCallHeld - 0: no calls held
> +   *           - 1: call is placed on hold or active/held calls swapped
> +   *           - 2: call o hold, no active call

Nit: Might be nice to make these enums at some point? But not gonna block it from landing on that. Might make a TODO of it though.

@@ +617,5 @@
> +   * mCallHeld - 0: no calls held
> +   *           - 1: call is placed on hold or active/held calls swapped
> +   *           - 2: call o hold, no active call
> +   */
> + 

supernit: extra whitespace (and below)

::: dom/bluetooth/BluetoothHfpManager.h
@@ +46,5 @@
>  
>    int mCurrentVgs;
>    int mCurrentCallIndex;
>    int mCurrentCallState;
> +  bool mCall;

Nit: This ends up being appended as an int and you treat it as such in the code, why not just make it an int then?

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version, r=qdot

try server:
https://tbpl.mozilla.org/?tree=Try&rev=c350bafc6db3
https://tbpl.mozilla.org/?tree=Try&rev=edc62fa2a4c3

Comment 4

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af631704f1e0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af631704f1e0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d00caf574dd5