Closed Bug 794349 Opened 9 years ago Closed 9 years ago

[b2g-bluetooth] Send correct +CIND: value to HS at SLC establishment

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: echou, Assigned: gyeh)

Details

Attachments

(1 file, 1 obsolete file)

+CIND: is used by AG for telling HS current call status during the period of SLC establishment. In bug 792002, we sent fixed +CIND values to remote HS to let SLC be created successfully, but it still needs to be revised.
Attached patch v1 patch (obsolete) — Splinter Review
Assignee: nobody → gyeh
Attachment #669395 - Flags: review?(kyle)
Comment on attachment 669395 [details] [diff] [review]
v1 patch

Review of attachment 669395 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +426,5 @@
> +    if (!AppendIntegerToString(cind, mCall) ||
> +        !AppendIntegerToString(cind, mCallSetup) ||
> +        !AppendIntegerToString(cind, mCallHeld)) {
> +      NS_WARNING("Failed to convert mCall/mCallSetup/mCallHeld to string");
> +    }    

Supernit: extra whitespace

@@ +615,5 @@
> +   *            - 2: an outgoing call set up is ongoing
> +   *            - 3: remote party being alerted in an outgoing call
> +   * mCallHeld - 0: no calls held
> +   *           - 1: call is placed on hold or active/held calls swapped
> +   *           - 2: call o hold, no active call

Nit: Might be nice to make these enums at some point? But not gonna block it from landing on that. Might make a TODO of it though.

@@ +617,5 @@
> +   * mCallHeld - 0: no calls held
> +   *           - 1: call is placed on hold or active/held calls swapped
> +   *           - 2: call o hold, no active call
> +   */
> + 

supernit: extra whitespace (and below)

::: dom/bluetooth/BluetoothHfpManager.h
@@ +46,5 @@
>  
>    int mCurrentVgs;
>    int mCurrentCallIndex;
>    int mCurrentCallState;
> +  bool mCall;

Nit: This ends up being appended as an int and you treat it as such in the code, why not just make it an int then?
Attachment #669395 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/af631704f1e0
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
You need to log in before you can comment on or make changes to this bug.