Closed Bug 794512 Opened 7 years ago Closed 7 years ago

Add a checkbox and preference to disable toast notifications for the Social API

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(firefox17 verified)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 --- verified

People

(Reporter: jaws, Assigned: jaws)

Details

(Whiteboard: [strings:2])

Attachments

(1 file)

Users should be able to disable the toast notification portion of the Social API, similar to hiding the sidebar.

There should be a menuitem in the social-statusarea-popup for this.
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #665113 - Flags: review?(mhammond)
Comment on attachment 665113 [details] [diff] [review]
Patch

The code in the patch is fine, but I've a couple of concerns (both mentioned in IRC):

* It would be ideal if this menu item was not shown in platforms that do not support such notifications - otherwise this checkbox will cause nothing to change for users on those platforms.  This might not be practical though (and who cares about osx 10.7 - if they were true fanbois they would have upgraded by now ;)

* I'm concerned "Show notifications" is too vague.  Some users may think the notification is the ambient toolbar area, for example.  One way to mitigate this would be to actually show a notification as the option is toggled - eg, when the option is enabled, a toast could popup saying "Social notifications have been enabled" (and probably the reverse too).  This would have the benefit of allowing people to "discover" what the option does simply by toggling it.
Attachment #665113 - Flags: review?(mhammond) → review+
Thanks for the speedy review Mark.

I changed the string to "Show desktop notifications" to clarify the affect fo the change.

Hiding this menuitem seems non-trivial based on the multiple ways that users can disable desktop notifications on various platforms, so I left it out of this patch.
5:36 PM <jaws> the detection of desktop notifications seems nontrivial though
5:36 PM <jaws> ok to leave that out?
5:37 PM <markh> sure

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1dec9463a62
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/d1dec9463a62
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #665113 - Flags: approval-mozilla-aurora+
Verified that the preference 'social.toast-notifications.enabled' and the menu item 'Show Desktop Notification' for the Social API are added and that users have the possibility to disable/enable the toast notifications.

Verified with Firefox 17 beta 5 on Win 7, Ubuntu 12.04 and Mac OS x 10.7:
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.