disable @supports for Firefox 17

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

({dev-doc-complete, relnote})

17 Branch
dev-doc-complete, relnote
Points:
---

Firefox Tracking Flags

(firefox17+ fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Should we be disabling @supports?  What criteria are we using to determine if it's safe to let through to Beta?
(Assignee)

Comment 1

5 years ago
Created attachment 665207 [details] [diff] [review]
patch to flip the pref to false

Comment 2

5 years ago
I think we shouldn't ship it in Beta if we don't plan to ship it in final.

So for 17, I think we should pref off, personally.
(Assignee)

Updated

5 years ago
Attachment #665207 - Flags: review?(dbaron)

Updated

5 years ago
tracking-firefox17: ? → +

Updated

5 years ago
Assignee: nobody → cam
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED

Comment 3

5 years ago
Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

r=me, for aurora; let's keep this on m-c for now.
Attachment #665207 - Flags: review?(dbaron) → review+
(Assignee)

Comment 4

5 years ago
Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 649740
User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs.
Testing completed (on m-c, etc.): No testing, it's just a pref flip.
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: N/A
Attachment #665207 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

Please make sure to land before Monday (to make the merge) and please mark bug 649740 as "disabled" for status-firefox17 when this lands.
Attachment #665207 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/06ebc898a9c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

5 years ago
Docs probably need to be updated to mention that it is preffed off for Firefox 17.
Keywords: dev-doc-needed
(Assignee)

Comment 8

5 years ago
Backed out for orange; the tests need tweaking so they don't fail when the pref is off:

https://hg.mozilla.org/releases/mozilla-aurora/rev/40414595ae48
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

5 years ago
Relanded: https://hg.mozilla.org/releases/mozilla-aurora/rev/b3966609aecc
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

5 years ago
Followup fix: https://hg.mozilla.org/releases/mozilla-aurora/rev/dde128c14e37

Updated

5 years ago
status-firefox17: --- → fixed
Whiteboard: [qa-]
Both: https://developer.mozilla.org/en-US/docs/CSS/@supports
and
https://developer.mozilla.org/en-US/docs/Firefox_17_for_developers

are up-to-date with the disabling (and the pref).
Keywords: dev-doc-needed → dev-doc-complete

Comment 12

5 years ago
It's not up-to-date for release notes: http://www.mozilla.org/en-US/firefox/17.0a2/auroranotes/
Keywords: relnote
Should do 18 as wel.
(Assignee)

Updated

5 years ago
Blocks: 814310
You need to log in before you can comment on or make changes to this bug.