Closed Bug 794696 Opened 8 years ago Closed 8 years ago

disable @supports for Firefox 17

Categories

(Core :: CSS Parsing and Computation, defect)

17 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox17 + fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

(Keywords: dev-doc-complete, relnote, Whiteboard: [qa-])

Attachments

(1 file)

Should we be disabling @supports?  What criteria are we using to determine if it's safe to let through to Beta?
I think we shouldn't ship it in Beta if we don't plan to ship it in final.

So for 17, I think we should pref off, personally.
Attachment #665207 - Flags: review?(dbaron)
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

r=me, for aurora; let's keep this on m-c for now.
Attachment #665207 - Flags: review?(dbaron) → review+
Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 649740
User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs.
Testing completed (on m-c, etc.): No testing, it's just a pref flip.
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: N/A
Attachment #665207 - Flags: approval-mozilla-aurora?
Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

Please make sure to land before Monday (to make the merge) and please mark bug 649740 as "disabled" for status-firefox17 when this lands.
Attachment #665207 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/06ebc898a9c3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Docs probably need to be updated to mention that it is preffed off for Firefox 17.
Keywords: dev-doc-needed
Backed out for orange; the tests need tweaking so they don't fail when the pref is off:

https://hg.mozilla.org/releases/mozilla-aurora/rev/40414595ae48
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded: https://hg.mozilla.org/releases/mozilla-aurora/rev/b3966609aecc
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
It's not up-to-date for release notes: http://www.mozilla.org/en-US/firefox/17.0a2/auroranotes/
Keywords: relnote
Blocks: 814310
You need to log in before you can comment on or make changes to this bug.