Closed
Bug 794696
Opened 8 years ago
Closed 8 years ago
disable @supports for Firefox 17
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: heycam, Assigned: heycam)
References
Details
(Keywords: dev-doc-complete, relnote, Whiteboard: [qa-])
Attachments
(1 file)
983 bytes,
patch
|
bzbarsky
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Should we be disabling @supports? What criteria are we using to determine if it's safe to let through to Beta?
Assignee | ||
Comment 1•8 years ago
|
||
![]() |
||
Comment 2•8 years ago
|
||
I think we shouldn't ship it in Beta if we don't plan to ship it in final. So for 17, I think we should pref off, personally.
Assignee | ||
Updated•8 years ago
|
Attachment #665207 -
Flags: review?(dbaron)
Updated•8 years ago
|
Updated•8 years ago
|
Assignee: nobody → cam
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
![]() |
||
Comment 3•8 years ago
|
||
Comment on attachment 665207 [details] [diff] [review] patch to flip the pref to false r=me, for aurora; let's keep this on m-c for now.
Attachment #665207 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 665207 [details] [diff] [review] patch to flip the pref to false [Approval Request Comment] Bug caused by (feature/regressing bug #): 649740 User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs. Testing completed (on m-c, etc.): No testing, it's just a pref flip. Risk to taking this patch (and alternatives if risky): Low. String or UUID changes made by this patch: N/A
Attachment #665207 -
Flags: approval-mozilla-aurora?
Comment 5•8 years ago
|
||
Comment on attachment 665207 [details] [diff] [review] patch to flip the pref to false Please make sure to land before Monday (to make the merge) and please mark bug 649740 as "disabled" for status-firefox17 when this lands.
Attachment #665207 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/06ebc898a9c3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•8 years ago
|
||
Docs probably need to be updated to mention that it is preffed off for Firefox 17.
Keywords: dev-doc-needed
Assignee | ||
Comment 8•8 years ago
|
||
Backed out for orange; the tests need tweaking so they don't fail when the pref is off: https://hg.mozilla.org/releases/mozilla-aurora/rev/40414595ae48
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•8 years ago
|
||
Relanded: https://hg.mozilla.org/releases/mozilla-aurora/rev/b3966609aecc
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•8 years ago
|
||
Followup fix: https://hg.mozilla.org/releases/mozilla-aurora/rev/dde128c14e37
Updated•8 years ago
|
status-firefox17:
--- → fixed
Comment 11•8 years ago
|
||
Both: https://developer.mozilla.org/en-US/docs/CSS/@supports and https://developer.mozilla.org/en-US/docs/Firefox_17_for_developers are up-to-date with the disabling (and the pref).
Keywords: dev-doc-needed → dev-doc-complete
Comment 12•8 years ago
|
||
It's not up-to-date for release notes: http://www.mozilla.org/en-US/firefox/17.0a2/auroranotes/
Keywords: relnote
Comment 13•8 years ago
|
||
Should do 18 as wel.
You need to log in
before you can comment on or make changes to this bug.
Description
•