794696 - disable @supports for Firefox 17

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Should we be disabling @supports?  What criteria are we using to determine if it's safe to let through to Beta?

Comment 1

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Attachment: patch to flip the pref to false

Comment 2

[Boris Zbarsky [:bzbarsky]]

I think we shouldn't ship it in Beta if we don't plan to ship it in final.

So for 17, I think we should pref off, personally.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

r=me, for aurora; let's keep this on m-c for now.

Comment 4

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 649740
User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs.
Testing completed (on m-c, etc.): No testing, it's just a pref flip.
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: N/A

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 665207 [details] [diff] [review]
patch to flip the pref to false

Please make sure to land before Monday (to make the merge) and please mark bug 649740 as "disabled" for status-firefox17 when this lands.

Comment 6

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/06ebc898a9c3

Comment 7

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Docs probably need to be updated to mention that it is preffed off for Firefox 17.

Comment 8

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Backed out for orange; the tests need tweaking so they don't fail when the pref is off:

https://hg.mozilla.org/releases/mozilla-aurora/rev/40414595ae48

Comment 9

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Relanded: https://hg.mozilla.org/releases/mozilla-aurora/rev/b3966609aecc

Comment 10

[Cameron McCormack (:heycam) (away Jan 26 - Feb 1)]

Followup fix: https://hg.mozilla.org/releases/mozilla-aurora/rev/dde128c14e37

Comment 11

[Jean-Yves Perrier [:teoli]]

Both: https://developer.mozilla.org/en-US/docs/CSS/@supports
and
https://developer.mozilla.org/en-US/docs/Firefox_17_for_developers

are up-to-date with the disabling (and the pref).

Comment 12

[Scoobidiver (away)]

It's not up-to-date for release notes: http://www.mozilla.org/en-US/firefox/17.0a2/auroranotes/

Comment 13

[David Baron :dbaron:]

Should do 18 as wel.