disable @supports for Firefox 18 and (probably) 19

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

18 Branch
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox18+ fixed, firefox19-)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #794696 +++

@supports should still be disabled for Firefox 18.
(Assignee)

Comment 1

5 years ago
Created attachment 684313 [details] [diff] [review]
make @supports tests work when pref is not set

I should have landed these test changes on inbound last time as well as on aurora.  I'll do that this time.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #684313 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

5 years ago
Created attachment 684314 [details] [diff] [review]
fliip pref for @supports off

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 649740
User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs in Beta and Release.
Testing completed (on m-c, etc.): No testing, it's just a pref flip -- but it worked last time. :)
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: N/A
Attachment #684314 - Flags: review?(bzbarsky)
Attachment #684314 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 3

5 years ago
Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

Switching to approval-mozilla-beta?, since I actually seem to have missed doing it before the aurora -> beta uplift.  The end result anyway is that the feature needs to be disabled for Firefox 18.
Attachment #684314 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
(Assignee)

Comment 4

5 years ago
(We need a better system for ensuring features are disabled on release/beta that is something other than "someone must remember to flip the pref on aurora just before the uplift".)
Comment on attachment 684313 [details] [diff] [review]
make @supports tests work when pref is not set

r=me
Attachment #684313 - Flags: review?(bzbarsky) → review+
Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

r=me
Attachment #684314 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/60b5863c9eed
Whiteboard: [leave open]
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/1edab0eaff90
https://hg.mozilla.org/releases/mozilla-beta/rev/30c43c54969b
https://hg.mozilla.org/mozilla-central/rev/60b5863c9eed
Flags: in-testsuite+
Will @supports stick for FF19? If not, please nominate this bug for that version as well.
tracking-firefox18: ? → +

Updated

5 years ago
Attachment #684314 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 11

5 years ago
Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

It's unlikely it'll be ready to unpref by Firefox 19.  But I'll wait to land it on Aurora until just before the merge.  In fact I'll set a reminder for myself this time. :)
Attachment #684314 - Flags: approval-mozilla-aurora?
Let's force pref on in mochitest like bug 779917.
(Assignee)

Comment 13

5 years ago
Yep; I'll do that in a separate bug.
(Assignee)

Comment 14

5 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/1936fb13468e
(Assignee)

Updated

5 years ago
Summary: disable @supports for Firefox 18 → disable @supports for Firefox 18 and (probably) 19
(Assignee)

Updated

5 years ago
tracking-firefox19: --- → ?

Updated

5 years ago
tracking-firefox19: ? → +

Updated

5 years ago
Attachment #684314 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
status-firefox18: --- → fixed
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
(In reply to Cameron McCormack (:heycam) from comment #11)
> Comment on attachment 684314 [details] [diff] [review]
> fliip pref for @supports off
> 
> It's unlikely it'll be ready to unpref by Firefox 19.  But I'll wait to land
> it on Aurora until just before the merge.  In fact I'll set a reminder for
> myself this time. :)

Did we decide to enable or disable for FF19?
(Assignee)

Comment 16

5 years ago
We continued to disable -- bug 814530 landed on Aurora to do this automatically.

Updated

5 years ago
tracking-firefox19: + → -
You need to log in before you can comment on or make changes to this bug.