Closed Bug 814310 Opened 11 years ago Closed 11 years ago

disable @supports for Firefox 18 and (probably) 19

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Version:
18 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox18 + fixed
firefox19 - ---

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(2 files)

make @supports tests work when pref is not set
14.03 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
fliip pref for @supports off
1.11 KB, patch
bzbarsky
: review+
akeybl
: approval-mozilla-aurora+
akeybl
: approval-mozilla-beta+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #794696 +++

@supports should still be disabled for Firefox 18.
I should have landed these test changes on inbound last time as well as on aurora.  I'll do that this time.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #684313 - Flags: review?(bzbarsky)
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 649740
User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs in Beta and Release.
Testing completed (on m-c, etc.): No testing, it's just a pref flip -- but it worked last time. :)
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: N/A
Attachment #684314 - Flags: review?(bzbarsky)
Attachment #684314 - Flags: approval-mozilla-aurora?
Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

Switching to approval-mozilla-beta?, since I actually seem to have missed doing it before the aurora -> beta uplift.  The end result anyway is that the feature needs to be disabled for Firefox 18.
Attachment #684314 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
(We need a better system for ensuring features are disabled on release/beta that is something other than "someone must remember to flip the pref on aurora just before the uplift".)
Comment on attachment 684313 [details] [diff] [review]
make @supports tests work when pref is not set

r=me
Attachment #684313 - Flags: review?(bzbarsky) → review+
Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

r=me
Attachment #684314 - Flags: review?(bzbarsky) → review+
Will @supports stick for FF19? If not, please nominate this bug for that version as well.
tracking-firefox18: ? → +
Attachment #684314 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

It's unlikely it'll be ready to unpref by Firefox 19.  But I'll wait to land it on Aurora until just before the merge.  In fact I'll set a reminder for myself this time. :)
Attachment #684314 - Flags: approval-mozilla-aurora?
Let's force pref on in mochitest like bug 779917.
Yep; I'll do that in a separate bug.
Summary: disable @supports for Firefox 18 → disable @supports for Firefox 18 and (probably) 19
tracking-firefox19: --- → ?
Attachment #684314 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
(In reply to Cameron McCormack (:heycam) from comment #11)
> Comment on attachment 684314 [details] [diff] [review]
> fliip pref for @supports off
> 
> It's unlikely it'll be ready to unpref by Firefox 19.  But I'll wait to land
> it on Aurora until just before the merge.  In fact I'll set a reminder for
> myself this time. :)

Did we decide to enable or disable for FF19?
We continued to disable -- bug 814530 landed on Aurora to do this automatically.
You need to log in before you can comment on or make changes to this bug.