814310 - disable @supports for Firefox 18 and (probably) 19

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

+++ This bug was initially created as a clone of Bug #794696 +++

@supports should still be disabled for Firefox 18.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: make @supports tests work when pref is not set

I should have landed these test changes on inbound last time as well as on aurora.  I'll do that this time.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: fliip pref for @supports off

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 649740
User impact if declined: We'd be violating our commitment to pref off features from pre-CR specs in Beta and Release.
Testing completed (on m-c, etc.): No testing, it's just a pref flip -- but it worked last time. :)
Risk to taking this patch (and alternatives if risky): Low.
String or UUID changes made by this patch: N/A

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

Switching to approval-mozilla-beta?, since I actually seem to have missed doing it before the aurora -> beta uplift.  The end result anyway is that the feature needs to be disabled for Firefox 18.

Comment 4

[Cameron McCormack (:heycam)]

(We need a better system for ensuring features are disabled on release/beta that is something other than "someone must remember to flip the pref on aurora just before the uplift".)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 684313 [details] [diff] [review]
make @supports tests work when pref is not set

r=me

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

r=me

Comment 7

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60b5863c9eed

Comment 8

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1edab0eaff90
https://hg.mozilla.org/releases/mozilla-beta/rev/30c43c54969b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60b5863c9eed

Comment 10

[Alex Keybl [:akeybl]]

Will @supports stick for FF19? If not, please nominate this bug for that version as well.

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 684314 [details] [diff] [review]
fliip pref for @supports off

It's unlikely it'll be ready to unpref by Firefox 19.  But I'll wait to land it on Aurora until just before the merge.  In fact I'll set a reminder for myself this time. :)

Comment 12

[Masatoshi Kimura [:emk]]

Let's force pref on in mochitest like bug 779917.

Comment 13

[Cameron McCormack (:heycam)]

Yep; I'll do that in a separate bug.

Comment 14

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1936fb13468e

Comment 15

[Alex Keybl [:akeybl]]

(In reply to Cameron McCormack (:heycam) from comment #11)
> Comment on attachment 684314 [details] [diff] [review]
> fliip pref for @supports off
> 
> It's unlikely it'll be ready to unpref by Firefox 19.  But I'll wait to land
> it on Aurora until just before the merge.  In fact I'll set a reminder for
> myself this time. :)

Did we decide to enable or disable for FF19?

Comment 16

[Cameron McCormack (:heycam)]

We continued to disable -- bug 814530 landed on Aurora to do this automatically.