Last Comment Bug 794880 - [Mac] The icon of the "Add Contact" and "Join Chat" toolbar buttons disappear when they are clicked while disabled
: [Mac] The icon of the "Add Contact" and "Join Chat" toolbar buttons disappear...
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Thunderbird 18.0
Assigned To: Richard Marti (:Paenglab)
Depends on:
Blocks: 709799
  Show dependency treegraph
Reported: 2012-09-27 04:01 PDT by Florian Quèze [:florian] [:flo]
Modified: 2012-10-05 11:20 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (2.08 KB, patch)
2012-09-27 13:09 PDT, Richard Marti (:Paenglab)
bugs: review+
bugs: ui‑review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description User image Florian Quèze [:florian] [:flo] 2012-09-27 04:01:30 PDT
This is a regression from bug 709799.

The CSS code in looks like this:
   101 #button-join-chat {
   102   list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
   103   -moz-image-region: rect(0px 36px 18px 18px);
   104 }
   106 #button-join-chat:hover:active {
   107   list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
   108   -moz-image-region: rect(32px 64px 64px 32px);
   109 }
   111 #button-join-chat:not([disabled="true"]):active {
   112   list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
   113   -moz-image-region: rect(18px 36px 36px 18px);
   114 }

I think the problem is that the second rule is applied even when the button is disabled.

Also, not that the lines 107 and 112 are pointless duplication here (and this duplication also exists for the Windows and Linux themes).
Comment 1 User image Richard Marti (:Paenglab) 2012-09-27 13:09:26 PDT
Created attachment 665616 [details] [diff] [review]

This rules should be removed in patch for bug 709799.
Comment 2 User image Andreas Nilsson (:andreasn) 2012-10-01 04:08:22 PDT
Comment on attachment 665616 [details] [diff] [review]

Code and ui looks good!
Comment 3 User image Florian Quèze [:florian] [:flo] 2012-10-01 04:53:19 PDT
Comment on attachment 665616 [details] [diff] [review]

[Approval Request Comment]
I think we can take this simple patch for Thunderbird 17 (but I wouldn't be too upset if we don't).
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-10-01 16:22:26 PDT
Comment 5 User image Florian Quèze [:florian] [:flo] 2012-10-05 11:20:55 PDT

Note You need to log in before you can comment on or make changes to this bug.