794880 - [Mac] The icon of the "Add Contact" and "Join Chat" toolbar buttons disappear when they are clicked while disabled

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Florian Quèze [:florian]]

This is a regression from bug 709799.

The CSS code in http://hg.mozilla.org/comm-central/annotate/f909272fc02a/mail/themes/pinstripe/mail/chat.css#l101 looks like this:
   101 #button-join-chat {
   102   list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
   103   -moz-image-region: rect(0px 36px 18px 18px);
   104 }
   105 
   106 #button-join-chat:hover:active {
   107   list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
   108   -moz-image-region: rect(32px 64px 64px 32px);
   109 }
   110 
   111 #button-join-chat:not([disabled="true"]):active {
   112   list-style-image: url("chrome://messenger/skin/icons/chat-toolbar.png");
   113   -moz-image-region: rect(18px 36px 36px 18px);
   114 }

I think the problem is that the second rule is applied even when the button is disabled.

Also, not that the lines 107 and 112 are pointless duplication here (and this duplication also exists for the Windows and Linux themes).

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

This rules should be removed in patch for bug 709799.

Comment 2

[Andreas Nilsson (:andreasn)]

Comment on attachment 665616 [details] [diff] [review]
patch

Code and ui looks good!

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 665616 [details] [diff] [review]
patch

[Approval Request Comment]
I think we can take this simple patch for Thunderbird 17 (but I wouldn't be too upset if we don't).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/10a38439e39a

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/comm-aurora/rev/38168c6bbcec