79502 - PAC: isPlainHostName not working

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[bnb]

In an autoproxy config isPlainHostName(host) doesn't return true for the
hostname "intranet" while !shExpMatch(host,".") does.

Comment 1

[bnb]

Attachment: Autoproxy that goes via the proxy for http://intranet/

Comment 2

[bnb]

Attachment: Autoproxy that *doesn't* go via the proxy for http://intranet/

Comment 3

[benc]

qa to me.

Comment 4

[Keyser Sose]

marking NEW.

Comment 5

[neeti]

PAC bugs to jpm

Comment 6

[Chase Tingley]

Attachment: patch

Comment 7

[Chase Tingley]

Not that I actually know javascript :), but this code is being evaluated twice;
hence it needs to be doubly escaped.  I gave this a spin and it appeared to work.

Comment 8

[[e-mail]]

Bug owner, can you review [e-mail]'s patch when you get a chance please?

Comment 9

[Jussi-Pekka Mantere]

Serge, can you take a look at these PAC issues? Thanks - Jussi-Pekka

Comment 10

[serge (gone)]

yes, that is correct, it needs to be doubly escaped,
because of double evaluation;
r=serge.

Comment 11

[rpotts (gone)]

sr=rpotts

Comment 12

[Chase Tingley]

Can anyone check this in for me?  Thanks.

Comment 13

[serge (gone)]

I'll do so. Thanks

Comment 14

[basic]

is this checked in?

Comment 15

[serge (gone)]

done
new revision: 1.11;

Comment 16

[benc]

+relnote & making test:

need to relnote if not working.

Comment 17

[benc]

VERIFIED:
in the soon-to-be posted PAC unit tests, you will be able to use
isPlainHostName.pac to verify this function works.