795023 - Use the TrustedUIManager from navigator.id Gaia implementation instead of the PopupManager to trigger a trusted dialog

Status: RESOLVED DUPLICATE of bug 794680

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

In order to implement the payment and identity flows for basecamp, navigator.id needs a trusted UI.

There is already a requirement for a trusted UI for mozPay, and the consensus appears to be that, for v1 at least, it will not be possible to make a generalized trusted ui api that would be available to native services like mozPay, id, etc.

We are fine with copy-and-paste solutions.  But in the end, the flows require a UI for nav.id that looks and acts exactly like the one for mozPay, and provides a way for us to message to and from the native nav.id code.

mozPay trustworthy UI: #768943

Comment 1

[Jason Smith [:jsmith]]

Is this a Gaia or Platform bug? It feels Gaiaish.

Comment 2

[Jason Smith [:jsmith]]

See also https://github.com/mozilla-b2g/gaia/issues/2580.

Comment 3

[Jason Smith [:jsmith]]

Migrated to Gaia GitHub - https://github.com/mozilla-b2g/gaia/issues/5323, as this is a front-end feature.

Comment 4

[Caitlin Galimidi [:c8o]]

Keeping this bug for project tracking purposes only. 
Developer details and technical requirements in github.

https://github.com/mozilla-b2g/gaia/issues/5323 (assigned to Fernando on the Gaia team)

Comment 5

[Jason Smith [:jsmith]]

I'd really prefer that we talk this out before you take action, as there's ways we can figure out tracking. But this is still not valid as it stands right now.

Comment 6

[Jason Smith [:jsmith]]

Okay, per talking with dietrich, all feature tracking that is v1 also needs to be in bugzilla. Moving this to Gaia in bugzilla and reopening.

Comment 7

[Jason Smith [:jsmith]]

My apologies for any confusion ferjm that this massive bug churn looks like. So 10/1 and after, they want any v1 tracking done in bugzilla. I'm closing the github issue, migrating the info to here, and starting tracking here.

Comment 8

[Ben Adida [:benadida]]

This bug's scope is limited to making the existing popup UI "trusted."

Comment 9

[Lucas Adamski [:ladamski]]

Fernando, how is this coming along?

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Lucas Adamski from comment #9)
> Fernando, how is this coming along?

No work done so far. This is blocked by Bug 794680. Once that one lands, this bug should be trivial to implement. It should only be a matter of using the TrustedUIManager instead of the PopupManager as it is currently used in https://bugzilla.mozilla.org/attachment.cgi?id=667617&action=diff#a/apps/system/js/identity.js_sec2

Comment 11

[Ben Adida [:benadida]]

Fernando: I think Zach Carter on my team can handle this if you'd like, following your example on nav.pay, since he's also writing the identity Gaia tests. What do you think? Now that you've created the example, as you say it should be easy :)

Plus, this means one patch, instead of two.

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Sounds good.

Comment 13

[Jason Smith [:jsmith]]

Per today's b2g meeting - at risk features do not block ship. Renoming.

Comment 14

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #13)
> Per today's b2g meeting - at risk features do not block ship. Renoming.

Ignore my comment here. This was a point of confusion on my part.

Comment 15

[Mike Connor [:mconnor]]

Restoring blocking flag.

Comment 16

[Zachary Carter [:zaach]]

PR awaiting review: https://github.com/mozilla-b2g/gaia/pull/5854

Comment 17

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Zachary Carter [:zaach] from comment #16)
> PR awaiting review: https://github.com/mozilla-b2g/gaia/pull/5854

I've attached the PR to Bug 794680 and ask for r? to Vivien.

Comment 18

[Zachary Carter [:zaach]]

Closing. See Bug 794680.

Comment 19

[Jason Smith [:jsmith]]

Talked to Zach about this in b2gpay - duping instead.