795078 - Thunderbird does not see user online and can't receive message from a contact with a singe quote in its resource

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Arnaud Abélard]

If a remote contact has a single quote (') in their XMPP resource, Thunderbird's Instant Messaging client will never see it online. If the contact messages the user using Thunderbird, no message will be received.

If the remote user removes the single quote from its resource, it will show as online in Thunderbird's contact list as expected and Thunderbird will receive messages from the remote user.

Comment 1

[Florian Quèze [:florian]]

Thanks for reporting this.

When Thunderbird receives a presence stanza with a single quote in the resource, this error appears in the Error Console:
Error: TypeError: this._account._parseJID(...) is null

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

The XMPP rfc says that the following characters are excluded for the "node" part of the JID:
    #x22 (")
    #x26 (&)
    #x27 (')
    #x2F (/)
    #x3A (:)
    #x3C (<)
    #x3E (>)
    #x40 (@)
http://xmpp.org/rfcs/rfc3920.html#rfc.section.A.5

But doesn't list any prohibited ASCII character for the resource part (http://xmpp.org/rfcs/rfc3920.html#rfc.section.B.5) so I think we shouldn't exclude any character there.

For the domain part, it just says it should be a valid domain name. The only characters that we really have to exclude in that part for our regexp to work are @ and / but I think the list we currently have is reasonable.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 666518 [details] [diff] [review]
Patch

The change looks good, I wish those regular expressions were a bit more readable, but I don't think there's a reasonable way to do that.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/d54b3307113e

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 666518 [details] [diff] [review]
Patch

[Approval Request Comment]
Low risk, so I think we should take this on comm-aurora for Thunderbird 17.

Comment 6

[Florian Quèze [:florian]]

http://hg.instantbird.org/instantbird/rev/d9aff99041bb

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/comm-aurora/rev/cb225ded5901