Closed
Bug 795296
Opened 12 years ago
Closed 12 years ago
Include the string that couldn't be parsed in XML parse errors of the XMPP stream
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird17 fixed)
RESOLVED
FIXED
Thunderbird 18.0
Tracking | Status | |
---|---|---|
thunderbird17 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file, 1 obsolete file)
4.70 KB,
patch
|
clokep
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
We need this to understand what's going on in bug 775977. The error messages we currently have when the XML parser doesn't like something we received on the XMPP stream are useless.
Attachment #665873 -
Flags: review?(clokep)
Assignee | ||
Comment 1•12 years ago
|
||
We can actually release _lastReceivedData as soon as we return from the parser.
Assignee: nobody → florian
Attachment #665873 -
Attachment is obsolete: true
Attachment #665873 -
Flags: review?(clokep)
Attachment #665874 -
Flags: review?(clokep)
Comment 2•12 years ago
|
||
Comment on attachment 665874 [details] [diff] [review] Patch v2 Much cleaner with deleting _lastReceivedData in the same method! Thanks for taking a look at this.
Attachment #665874 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/82d5e37e3a60
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment 4•12 years ago
|
||
Also checked in for Instantbird: http://hg.instantbird.org/instantbird/rev/1c2cfa0b5a27
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 665874 [details] [diff] [review] Patch v2 [Approval Request Comment] This patch is required to debug all XMPP disconnection bugs caused by us failing to parse something the server sent us. It was required to understand the situation in bug 775977, and could help again for https://getsatisfaction.com/mozilla_messaging/topics/facebook_chat-tqpop#reply_10244540
Attachment #665874 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #665874 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/f0fc13700902
status-thunderbird17:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•