Include the string that couldn't be parsed in XML parse errors of the XMPP stream

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 18.0

Thunderbird Tracking Flags

(thunderbird17 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 665873 [details] [diff] [review]
Patch

We need this to understand what's going on in bug 775977.

The error messages we currently have when the XML parser doesn't like something we received on the XMPP stream are useless.
Attachment #665873 - Flags: review?(clokep)
Created attachment 665874 [details] [diff] [review]
Patch v2

We can actually release _lastReceivedData as soon as we return from the parser.
Assignee: nobody → florian
Attachment #665873 - Attachment is obsolete: true
Attachment #665873 - Flags: review?(clokep)
Attachment #665874 - Flags: review?(clokep)
Comment on attachment 665874 [details] [diff] [review]
Patch v2

Much cleaner with deleting _lastReceivedData in the same method! Thanks for taking a look at this.
Attachment #665874 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/82d5e37e3a60
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Also checked in for Instantbird: http://hg.instantbird.org/instantbird/rev/1c2cfa0b5a27
Comment on attachment 665874 [details] [diff] [review]
Patch v2

[Approval Request Comment]
This patch is required to debug all XMPP disconnection bugs caused by us failing to parse something the server sent us.
It was required to understand the situation in bug 775977, and could help again for https://getsatisfaction.com/mozilla_messaging/topics/facebook_chat-tqpop#reply_10244540
Attachment #665874 - Flags: approval-comm-aurora?
Attachment #665874 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/f0fc13700902
status-thunderbird17: --- → fixed
You need to log in before you can comment on or make changes to this bug.