795518 - content api for closing panels

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

social panels (flyout, status and chat) need an api for closing the panel.  One was implemented for flyouts, it should be updated or verified to work with the panel that is calling the api.

Comment 1

[Shane Caraveo (:mixedpuppy)]

This is related to but not dependent on bug 794640

Comment 2

[Mark Hammond [:markh] [:mhammond]]

On IRC, Jaws suggested we just use window.close.  I've a patch which uses the DOMWindowClose event to implement this (no tests and no support for chat windows yet) - but what d'ya reckon?

Comment 3

[Shane Caraveo (:mixedpuppy)]

cool, I would much prefer window.close.  iirc we pass back the window object on any opening api.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Have window.close() close panels and chats

window.close(), when used on a chatbar window or a panel window will close the chat/panel.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 666805 [details] [diff] [review]
Have window.close() close panels and chats

Review of attachment 666805 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/social/MozSocialAPI.jsm
@@ +174,4 @@
>      // set a timer which will fire after the unload events have all fired.
>      schedule(function () { port.close(); });
>    });
> +  targetWindow.addEventListener("DOMWindowClose", function(evt) {

Please name this function and remove the event listener.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

As discussed on IRC, the listener can't be removed as it might fire multiple times.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b58a62ebfd9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b58a62ebfd9

Comment 8

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/94b299dc86b0