795528 - Update Google search plugin favicon for Japanese locales

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Frank Yan (:fryn)]

We're updating the favicon of the Google search plugin for the en-US locale, which updates it for all locales except Kurdish and Japanese.
Please update it for the Japanese locales (ja and ja-JP-mac) too.
See the desktop patch in bug 783778 to see how to change the data URI image to the new one.

Comment 1

[ABE Hiroki (:hATrayflood)]

Attachment: for browser

Comment 2

[ABE Hiroki (:hATrayflood)]

Attachment: for mobile

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 666330 [details] [diff] [review]
for mobile

Review of attachment 666330 [details] [diff] [review]:
-----------------------------------------------------------------

I'm holding off on the review here until I got an answer in the en-US bug why we'd be claiming those images to be 16x16.

Feel free to land the browser one already, as usual with a reference to the bug number and my review.

Comment 4

[Frank Yan (:fryn)]

(In reply to Axel Hecht [:Pike] from comment #3)
> I'm holding off on the review here until I got an answer in the en-US bug
> why we'd be claiming those images to be 16x16.

We're doing that, because nsSearchService.js expects the width and height attributes to be 16, and I guess they decided it wasn't worth the trouble to fix that code at that time.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 666330 [details] [diff] [review]
for mobile

Review of attachment 666330 [details] [diff] [review]:
-----------------------------------------------------------------

oh, but well, yeah.

Comment 6

[Nagato KASAKI]

Updated for mobile.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/2016fd99e548
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/6037841b8505

Comment 7

[Masahiko Imanaka [:marsf]]

Updated for browser.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/6e04821a605c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/89ad99cf41be

They were forgotten. :(