Closed Bug 795528 Opened 7 years ago Closed 7 years ago

Update Google search plugin favicon for Japanese locales

Categories

(Mozilla Localizations :: ja / Japanese, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fryn, Unassigned)

References

Details

(Keywords: productization)

Attachments

(2 files)

We're updating the favicon of the Google search plugin for the en-US locale, which updates it for all locales except Kurdish and Japanese.
Please update it for the Japanese locales (ja and ja-JP-mac) too.
See the desktop patch in bug 783778 to see how to change the data URI image to the new one.
Attached patch for browserSplinter Review
Attachment #666329 - Flags: review?(l10n)
Attached patch for mobileSplinter Review
Attachment #666330 - Flags: review?(l10n)
Attachment #666329 - Flags: review?(l10n) → review+
Comment on attachment 666330 [details] [diff] [review]
for mobile

Review of attachment 666330 [details] [diff] [review]:
-----------------------------------------------------------------

I'm holding off on the review here until I got an answer in the en-US bug why we'd be claiming those images to be 16x16.

Feel free to land the browser one already, as usual with a reference to the bug number and my review.
(In reply to Axel Hecht [:Pike] from comment #3)
> I'm holding off on the review here until I got an answer in the en-US bug
> why we'd be claiming those images to be 16x16.

We're doing that, because nsSearchService.js expects the width and height attributes to be 16, and I guess they decided it wasn't worth the trouble to fix that code at that time.
Comment on attachment 666330 [details] [diff] [review]
for mobile

Review of attachment 666330 [details] [diff] [review]:
-----------------------------------------------------------------

oh, but well, yeah.
Attachment #666330 - Flags: review?(l10n) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.