783778 - Update Google favicon in the search bar

Status: VERIFIED FIXED

(Firefox :: Search, enhancement)

Description

[u428464]

The Google favicon has been updated to a simple blue one instead of multicolored one. It should be updated in the search bar. The new color could also be useful for the future streamlining of the search bar.

Comment 1

[Kev Needham [:kev]]

Attachment: Google Search Favicon 32x32

From Google, updated plugin favicon that can be used in-product.

Comment 2

[:Margaret Leibovic]

Similarly to bug 773641, we'll want a 16x16 icon for desktop.

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to Margaret Leibovic [:margaret] from comment #2)
> Similarly to bug 773641, we'll want a 16x16 icon for desktop.

Can we use the 16x16 one http://google.com/favicon.ico ? It would be great to get this in so we can also use it for the HiDPI work :)

Comment 4

[Kev Needham [:kev]]

Attachment: Google Search Icon 16x16

I believe this is the same as the website favicon, but this is the file provided by Google for 16x16 application.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Updated Google Icon - Desktop

Updated Google Search Icon

Comment 6

[Stephen Horlander [:shorlander]]

Attachment: Screenshot - Desktop

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: Updated Google Icon - Mobile

I don't have a mobile build setup at the moment but I just replaced the data URI with the new image. So should work :)

Comment 8

[:Margaret Leibovic]

Comment on attachment 666078 [details] [diff] [review]
Updated Google Icon - Mobile

The new Google icon looks good, but you accidentally changed the Wikipedia icon as well. Get rid of that change before you land this :)

Screenshot: https://dl.dropbox.com/u/3358452/2012-09-28%2016.28.04.png

Comment 9

[Stephen Horlander [:shorlander]]

Well that's embarrassing. Not sure how that happened :)

Comment 10

[Stephen Horlander [:shorlander]]

Attachment: Updated Google Icon - Mobile

Fixed patch carrying r+

Comment 11

[Justin Dolske [:Dolske]]

Comment on attachment 666076 [details] [diff] [review]
Updated Google Icon - Desktop

rs=me, but we should also take a look at what the l10n flavors of this are... istr in the past we've run scripts against the l10n repos to update all of them. Check hg history on this and other google.xmls?

Comment 12

[Frank Yan (:fryn)]

(In reply to Justin Dolske [:Dolske] from comment #11)
> Comment on attachment 666076 [details] [diff] [review]
> Updated Google Icon - Desktop
> 
> rs=me, but we should also take a look at what the l10n flavors of this
> are... istr in the past we've run scripts against the l10n repos to update
> all of them. Check hg history on this and other google.xmls?

It's a weird situation: we use the en-US one for all locales, except three. I'll file bugs to fix those three.

Comment 13

[Frank Yan (:fryn)]

Actually, it's just two: Kurdish and Japanese.
(Sorry for the bugspam.)

Comment 14

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e88f05f32618

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e88f05f32618

Comment 16

[Aaron Train [:aaronmt]]

Can we get a mobile patch too?

/mobile/locales/en-US/searchplugins/google.xml

Comment 17

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #16)
> Can we get a mobile patch too?
> 
> /mobile/locales/en-US/searchplugins/google.xml

nm, the mobile patch attached needs to land

Comment 18

[:Margaret Leibovic]

/me shakes fist at fryn

https://hg.mozilla.org/integration/mozilla-inbound/rev/d95f2229451e

Comment 19

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/d95f2229451e

Comment 20

[Axel Hecht [:Pike]]

Comment on attachment 666110 [details] [diff] [review]
Updated Google Icon - Mobile

Review of attachment 666110 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/locales/en-US/searchplugins/google.xml
@@ +4,5 @@
>  
>  <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
>  <ShortName>Google</ShortName>
>  <InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAACv0lEQVR42sWX208TURDG958x8M+It5CoDxojGn0wPvCg8UljYhRjBCpqJBQbL6lgI5JyERpFRLAiF7GiqI0QbUCIlm1pQ6XM556z7dQNbTl1l/olkzTd0zO/THe+OUfbXk8ithnhM0I3Alscusxl5tRE8gojokagzBEVubUMDUqJ4x6CNwhMfQOiCSCVRl6tpYFHY8DeGwX38mkllF1u9OwDkEwB90cIZx4SrvQSpiNgEYC218DFLsKR1k33jGuqyfcZyWeXgPQ6UOu1PtvZSBj6BJaeBI7eVttXGWDkC4REorzPq5sIS3GwQt/hHMDpdkJWd4YLr3MPEv7WibsOAfgnwbo1UHjdwWYrwLWAQwDjc2D53hQv7fwyWC2DDgGMzYI1HSkKIFqTVdftEED7KFhEwGH35gCpNWD/TfsAbDxEYAXe56/CLheJFpTyDDnchg+CsKixf+Mab2ZN11ugqt5ZALGhdL+1dM7xhj+bIK4AYWIOUq0v+DeOAnDUuEmWd3AGCIaBnytgie/kOvsA6rEYA8vzksoPoCfBWtCBQy1lBuiZgkW/EsCptq0D4Ol3zEM495ik263TxnNAXbdzANzj9X3SlqXJrBoxM29Ox9538rNFAup8p0MAtV7p8Txmz3YIIOuaHQ3SByyGlViFOEfYApBl/m32vvy/qxqKr7/UxV6R8QUbANVN/JbLft/tUvu7rj4hZW/QVDd6/hEoxTUX9OwJygZA5wRYA6oAPBXZnP4ZQHp/VstJYI9LvQI/YuYBtsZtA+DkPQIhp76Q2pS73EOAeTy334Yd47BITD0BVsigrj8lpNLSG0RrKgHoxcspp58wH4siUfMN90+a8SoM2TFLcXEpUX5X4spXswPNJHt69CvkBEymcpeQ8CLQHwIu+NmgVIKvZpX/8XJamb2eV2QqEStD4pjMZebU/gD3oidE+JhxZwAAAABJRU5ErkJggg==</Image>

I understand that this patch doesn't change that, but is there a reason why we claim this image to be 16x16 instead of 32x32?

Comment 21

[:Margaret Leibovic]

(In reply to Axel Hecht [:Pike] from comment #20)

> I understand that this patch doesn't change that, but is there a reason why
> we claim this image to be 16x16 instead of 32x32?

I believe it's because the search service requires that the height/width specified by 16x16, and we were too lazy to update that hard-coded requirement:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#1586

Comment 22

[Axel Hecht [:Pike]]

Filed bug 795866

Comment 23

[Cristian Nicolae (:xti)]

Can it be nominalized for Firefox Beta 17?

Comment 24

[Aaron Train [:aaronmt]]

(In reply to Cristian Nicolae (:xti) from comment #23)
> Can it be nominalized for Firefox Beta 17?

It can ride the train.

Comment 25

[Cristian Nicolae (:xti)]

This issue is fixed on the latest Nightly and Aurora build. The Google blue icon is displayed for the Google search engine. Closing bug as verified fixed on:

Firefox 19.0a1 (2012-11-15)
Device: Galaxy S2
OS: Android 4.0.3