Update Google favicon in the search bar

VERIFIED FIXED in Firefox 18

Status

()

Firefox
Search
--
enhancement
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: ge3k0s, Assigned: shorlander)

Tracking

Trunk
Firefox 18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox18 verified, firefox19 verified)

Details

(URL)

Attachments

(5 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
The Google favicon has been updated to a simple blue one instead of multicolored one. It should be updated in the search bar. The new color could also be useful for the future streamlining of the search bar.
(Reporter)

Updated

6 years ago
Keywords: uiwanted

Updated

6 years ago
Status: UNCONFIRMED → NEW
Component: Theme → Search
Ever confirmed: true
Keywords: uiwanted

Updated

6 years ago
Blocks: 785381

Comment 1

6 years ago
Created attachment 655997 [details]
Google Search Favicon 32x32

From Google, updated plugin favicon that can be used in-product.

Comment 2

6 years ago
Similarly to bug 773641, we'll want a 16x16 icon for desktop.
(Assignee)

Comment 3

6 years ago
(In reply to Margaret Leibovic [:margaret] from comment #2)
> Similarly to bug 773641, we'll want a 16x16 icon for desktop.

Can we use the 16x16 one http://google.com/favicon.ico ? It would be great to get this in so we can also use it for the HiDPI work :)

Comment 4

6 years ago
Created attachment 665908 [details]
Google Search Icon 16x16

I believe this is the same as the website favicon, but this is the file provided by Google for 16x16 application.
(Assignee)

Comment 5

6 years ago
Created attachment 666076 [details] [diff] [review]
Updated Google Icon - Desktop

Updated Google Search Icon
Attachment #666076 - Flags: review?(dolske)
(Assignee)

Comment 6

6 years ago
Created attachment 666077 [details]
Screenshot - Desktop
(Assignee)

Comment 7

6 years ago
Created attachment 666078 [details] [diff] [review]
Updated Google Icon - Mobile

I don't have a mobile build setup at the moment but I just replaced the data URI with the new image. So should work :)
Attachment #666078 - Flags: review?(margaret.leibovic)

Comment 8

6 years ago
Comment on attachment 666078 [details] [diff] [review]
Updated Google Icon - Mobile

The new Google icon looks good, but you accidentally changed the Wikipedia icon as well. Get rid of that change before you land this :)

Screenshot: https://dl.dropbox.com/u/3358452/2012-09-28%2016.28.04.png
Attachment #666078 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 9

6 years ago
Well that's embarrassing. Not sure how that happened :)
(Assignee)

Comment 10

6 years ago
Created attachment 666110 [details] [diff] [review]
Updated Google Icon - Mobile

Fixed patch carrying r+
Attachment #666110 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #666078 - Attachment is obsolete: true
Comment on attachment 666076 [details] [diff] [review]
Updated Google Icon - Desktop

rs=me, but we should also take a look at what the l10n flavors of this are... istr in the past we've run scripts against the l10n repos to update all of them. Check hg history on this and other google.xmls?
Attachment #666076 - Flags: review?(dolske) → review+

Comment 12

6 years ago
(In reply to Justin Dolske [:Dolske] from comment #11)
> Comment on attachment 666076 [details] [diff] [review]
> Updated Google Icon - Desktop
> 
> rs=me, but we should also take a look at what the l10n flavors of this
> are... istr in the past we've run scripts against the l10n repos to update
> all of them. Check hg history on this and other google.xmls?

It's a weird situation: we use the en-US one for all locales, except three. I'll file bugs to fix those three.

Comment 13

6 years ago
Actually, it's just two: Kurdish and Japanese.
(Sorry for the bugspam.)

Updated

6 years ago
Blocks: 795527

Updated

6 years ago
Blocks: 795528

Comment 14

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e88f05f32618
Assignee: nobody → shorlander
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 18
https://hg.mozilla.org/mozilla-central/rev/e88f05f32618
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Can we get a mobile patch too?

/mobile/locales/en-US/searchplugins/google.xml
(In reply to Aaron Train [:aaronmt] from comment #16)
> Can we get a mobile patch too?
> 
> /mobile/locales/en-US/searchplugins/google.xml

nm, the mobile patch attached needs to land

Updated

6 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/d95f2229451e
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Comment 20

6 years ago
Comment on attachment 666110 [details] [diff] [review]
Updated Google Icon - Mobile

Review of attachment 666110 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/locales/en-US/searchplugins/google.xml
@@ +4,5 @@
>  
>  <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
>  <ShortName>Google</ShortName>
>  <InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAACv0lEQVR42sWX208TURDG958x8M+It5CoDxojGn0wPvCg8UljYhRjBCpqJBQbL6lgI5JyERpFRLAiF7GiqI0QbUCIlm1pQ6XM556z7dQNbTl1l/olkzTd0zO/THe+OUfbXk8ithnhM0I3Alscusxl5tRE8gojokagzBEVubUMDUqJ4x6CNwhMfQOiCSCVRl6tpYFHY8DeGwX38mkllF1u9OwDkEwB90cIZx4SrvQSpiNgEYC218DFLsKR1k33jGuqyfcZyWeXgPQ6UOu1PtvZSBj6BJaeBI7eVttXGWDkC4REorzPq5sIS3GwQt/hHMDpdkJWd4YLr3MPEv7WibsOAfgnwbo1UHjdwWYrwLWAQwDjc2D53hQv7fwyWC2DDgGMzYI1HSkKIFqTVdftEED7KFhEwGH35gCpNWD/TfsAbDxEYAXe56/CLheJFpTyDDnchg+CsKixf+Mab2ZN11ugqt5ZALGhdL+1dM7xhj+bIK4AYWIOUq0v+DeOAnDUuEmWd3AGCIaBnytgie/kOvsA6rEYA8vzksoPoCfBWtCBQy1lBuiZgkW/EsCptq0D4Ol3zEM495ik263TxnNAXbdzANzj9X3SlqXJrBoxM29Ox9538rNFAup8p0MAtV7p8Txmz3YIIOuaHQ3SByyGlViFOEfYApBl/m32vvy/qxqKr7/UxV6R8QUbANVN/JbLft/tUvu7rj4hZW/QVDd6/hEoxTUX9OwJygZA5wRYA6oAPBXZnP4ZQHp/VstJYI9LvQI/YuYBtsZtA+DkPQIhp76Q2pS73EOAeTy334Yd47BITD0BVsigrj8lpNLSG0RrKgHoxcspp58wH4siUfMN90+a8SoM2TFLcXEpUX5X4spXswPNJHt69CvkBEymcpeQ8CLQHwIu+NmgVIKvZpX/8XJamb2eV2QqEStD4pjMZebU/gD3oidE+JhxZwAAAABJRU5ErkJggg==</Image>

I understand that this patch doesn't change that, but is there a reason why we claim this image to be 16x16 instead of 32x32?

Comment 21

6 years ago
(In reply to Axel Hecht [:Pike] from comment #20)

> I understand that this patch doesn't change that, but is there a reason why
> we claim this image to be 16x16 instead of 32x32?

I believe it's because the search service requires that the height/width specified by 16x16, and we were too lazy to update that hard-coded requirement:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#1586

Comment 22

6 years ago
Filed bug 795866
Can it be nominalized for Firefox Beta 17?
(In reply to Cristian Nicolae (:xti) from comment #23)
> Can it be nominalized for Firefox Beta 17?

It can ride the train.
This issue is fixed on the latest Nightly and Aurora build. The Google blue icon is displayed for the Google search engine. Closing bug as verified fixed on:

Firefox 19.0a1 (2012-11-15)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox18: --- → verified
status-firefox19: --- → verified
You need to log in before you can comment on or make changes to this bug.