796045 - Improve install/update API for hosted apps

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

There are a couple of things we should do here:

* When we do the initial download of the appcache for a hosted app, make sure
  that we use the right cookiejar.  Right now I think we use the "no app" jar
  when we're doing the initial appcache download of a hosted app, which
  effectively means that the data is wasted. This can be done by using the API
  in bug 794663.

* Hook up the checkForUpdate function to the API added in bug 751754.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think this is a blocker since without this we are effectively not installing hosted apps that use appcache at installation time. Despite the fact that we go through the effort of downloading it.

Comment 2

[Andrew Overholt [:overholt]]

Wasting bandwidth is bad.

Comment 3

[Andrew Overholt [:overholt]]

I know you're at TPAC, Jonas, but can you provide a status update when you get home?  Should we give this to someone else?

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 796045: Prepopulate apps cache for specific mozbrowser frames r=fabrice

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 676764 [details] [diff] [review]
Bug 796045: Prepopulate apps cache for specific mozbrowser frames r=fabrice

Carry over r+ from bug 796278.

Comment 7

[Dietrich Ayala (:dietrich)]

P1 blocker that's had review for a couple of days. Ready to land?

Comment 8

[Jason Duell]

It would be lovely to have test coverage: this fix finally gives us what we need to actually test appcache via appinstall; test for appcache entries existing; uninstall; test for lack of entries.   But I'm also OK with landing and doing testing in another bug (as long as we file one and mark it as important).

Comment 9

[Lucas Adamski [:ladamski]]

I say land then test, esp. since nobody seems to be working on them ATM.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/548983f0b791

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/548983f0b791

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I filed bug 809947 on the remaining work.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7bc199aeb7f0

Comment 14

[Manuela Muntean [Away]]

Is there any visible effect of this bug fix ? What should QA be looking for when verifying this fix?

Comment 15

[Jason Smith [:jsmith]]

(In reply to Manuela Muntean from comment #14)
> Is there any visible effect of this bug fix ? What should QA be looking for
> when verifying this fix?

This is verified through testing that appcache preloading probably still works as expected with b2g.

Comment 16

[Jason Smith [:jsmith]]

Verified on 11/26.