809947 - Implement app.checkForUpdate for hosted apps

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

+++ This bug was initially created as a clone of Bug #796045 +++

The remaining work here is:

* Hook up the checkForUpdate function to the API added in bug 751754.

Comment 1

[Alex Keybl [:akeybl]]

Marking for C2, given this meets the criteria of known P1/P2 bugs at the end of C1.

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: patch

Fernando, I tested with a local version of http://owapps.cloudfoundry.com/ 
Please double check that it's also working for you.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 687966 [details] [diff] [review]
patch

Review of attachment 687966 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested and works for me too.

::: dom/apps/src/Webapps.jsm
@@ +1041,5 @@
> +              aMm.sendAsyncMessage("Webapps:CheckForUpdate:Return:OK", aData);
> +            }
> +          }
> +          let updateSvc = Cc["@mozilla.org/offlinecacheupdate-service;1"]
> +                            .getService(Ci.nsIOfflineCacheUpdateService);

I think you can use here the 'updateSvc' that you got from the lazy getter in line 46.

@@ +1042,5 @@
> +            }
> +          }
> +          let updateSvc = Cc["@mozilla.org/offlinecacheupdate-service;1"]
> +                            .getService(Ci.nsIOfflineCacheUpdateService);
> +          updateSvc.checkForUpdate(Services.io.newURI(aData.manifestURL, null, null),

At some point we would need to clean this file from lines longer than 80 chars :)

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c4bd5ee4114

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2c4bd5ee4114

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e5b55985b888
https://hg.mozilla.org/releases/mozilla-beta/rev/c1b5d8415919