897386 - swapDocShells is not a function

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am seeing an exception "swapDocShells is not a function" when detaching Firebug from the browser window.

The exception appears only in Nightly (started 07/19), Aurora works fine.

STR:

1) Install Firebug in Nightly
https://getfirebug.com/releases/firebug/1.12/firebug-1.12.0b4.xpi
2) Start the browser, open Firebug (F12)
3) Detach Firebug (Open Firebug in New Window)
 
-> There is an exception "swapDocShells is not a function"

Here is the swapDocShells API usage in Firebug source:
https://github.com/firebug/firebug/blob/master/extension/content/firebug/chrome/chrome.js#L1201


Honza

Comment 1

[Sebastian Zartner [:sebo]]

The API call actually happens some lines above:
https://github.com/firebug/firebug/blob/master/extension/content/firebug/chrome/chrome.js#L1183

Sebastian

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am not sure if the Component for this bug report is properly set.
Honza

Comment 3

[Boris Zbarsky [:bzbarsky]]

> The exception appears only in Nightly (started 07/19)

What are the changeset IDs for the last working and first broken nightly?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

According to Firebug Test bot:
https://getfirebug.com/testresults

Last working: 0cef7fe1f04b5124680e4fd2e4c459bcc29629e4 (App Changeset af4e3ce8c487)
First broken: 91aec080bc917ae3bb78b0a39ea7f30189706910 (App Changeset 0d0263a58f06)

Honza

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK, so http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af4e3ce8c487&tochange=0d0263a58f06

Blake, anything in there that might have affected XBL binding teardown?

Jan, are you able to bisect builds to narrow this down further?

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

ftp://ftp.mozilla.org/pub/firefox/nightly/2013-07-18-03-02-01-mozilla-central/firefox-25.0a1.en-US.win32.zip
OK Built from http://hg.mozilla.org/mozilla-central/rev/f26e4c26ce4a

ftp://ftp.mozilla.org/pub/firefox/nightly/2013-07-19-03-02-04-mozilla-central/firefox-25.0a1.en-US.win32.zip
OK Built from http://hg.mozilla.org/mozilla-central/rev/af4e3ce8c487

ftp://ftp.mozilla.org/pub/firefox/nightly/2013-07-19-mozilla-central-debug/firefox-25.0a1.en-US.debug-win32.installer.exe
FAILS Built from http://hg.mozilla.org/mozilla-central/rev/0d0263a58f06

ftp://ftp.mozilla.org/pub/firefox/nightly/2013-07-20-03-02-14-mozilla-central/firefox-25.0a1.en-US.win32.zip
FAILS Built from http://hg.mozilla.org/mozilla-central/rev/bf73e10f5e54

Here are some results of my testing

Honza

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

It's possible that this is a regression from bug 796061.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Hack to allow adopted browsers to still have XBL bindings.

wchen and I debugged this yesterday and found that the Firebug code works
because of two distinct bugs:

  * nsIDocument::AdoptNode doesn't tear down XBL bindings on nodes that
    weren't in a document.
  * Once we'd updated the <browser>'s nodeinfo and it was in the new document,
    we could no longer find the XBL binding because it wasn't in
    OwnerDoc()->GetBindingManager()! That meant that we were perfectly happy
    to bind a new binding in the new document, making things mostly work.

With the patch in bug 796061, the second bug no longer happens -- we now track
the XBL binding across the node adoption and badness ensues. Unfortunately, we
can't fix this by simply calling into the binding manager from Adopt because
that can run script that needs to run off of a scriptrunner and the
scriptrunner in this case will run too late (after we need to re-attach the
binding once the node is in the new document).

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e1646540da

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0e1646540da

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Just updated to latest Nightly and the problem is gone.
Built from http://hg.mozilla.org/mozilla-central/rev/a0dd80f800e2

Thanks!
Honza