796135 - Provide some obvious UI for scripts filtering

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Currently, there's little indication on how scripts filtering works. The only thing that happens is that the first matched file is selected and the unmatched files are hidden (in an unexpanded menulist).

We either need a perpetual-expanded-dropdown-while-filtering, or some other nicer UI. I was thinking of reusing the doorhanger/popup mechanism here as well, since we already have one for operators.

Comment 2

[Victor Porof [:vporof][:vp]]

Obviously this should be keyboard accessible.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

WIP. Doesn't do much.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: looks like this

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v2

Works! Needs a test.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v3

onClick all the things!

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v3

Added test.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 690359 [details] [diff] [review]
v3

Review of attachment 690359 [details] [diff] [review]:
-----------------------------------------------------------------

I'm starting to think I'd just use the debugger frontend for coding, since it's growing to a pretty decent clone of Sublime Text! My only gripe with this patch is the slow response in sites like GitHub, where bug 819945 is biting us.

::: browser/devtools/debugger/debugger-toolbar.js
@@ +1057,5 @@
> +create({ constructor: FilteredSourcesView, proto: MenuContainer.prototype }, {
> +  /**
> +   * Initialization function, called when the debugger is started.
> +   */
> +  initialize: function DVFS_initialize() {

I wonder if this will make the debugger frontend slower to appear when opening. We should gather some data first though, before lazy-loading everything.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #8)
> Comment on attachment 690359 [details] [diff] [review]
> v3

> ::: browser/devtools/debugger/debugger-toolbar.js
> @@ +1057,5 @@
> > +create({ constructor: FilteredSourcesView, proto: MenuContainer.prototype }, {
> > +  /**
> > +   * Initialization function, called when the debugger is started.
> > +   */
> > +  initialize: function DVFS_initialize() {
> 
> I wonder if this will make the debugger frontend slower to appear when
> opening. We should gather some data first though, before lazy-loading
> everything.

I wouldn't worry about it, since the only bottleneck in this function is a document.createElement("panel");. We're doing the same thing with the whole UI anyway, so optimizing here would be a bad place to start :)

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/4eb861243857

Comment 12

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff