796157 - Review b2g/locales/en-US for string freeze

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Axel Hecht [:Pike]]

We'll need a string freeze for b2g on mozilla-central in time for uplift to aurora.

I think most of the files there aren't needed, actually, just netError.dtd and appstrings.properties make sense to me right now.

Also, the branding files need review, those potentially show up in network error messages generated by gecko, and I'm pretty sure we don't want "B2G" to show up there? Those are currently under b2g/branding/.../locales/en-US

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Axel: I assume you are the right assignee? If not, can you find the right person to do this?

Comment 2

[Axel Hecht [:Pike]]

This needs a functional review of someone that knows what b2g does with those strings.

I don't think that we can help here from the l10n side, the questions is more about:

If we trigger a netError.dtd message that includes brand.dtd's brandShortName, what should that name be?

Folks from the l10n side won't be able to answer that, I'm afraid.

Also, I don't know why many of the files are actually there, I'd remove all but the two I mentioned in the initial comment, plus the branding.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Axel: Can you chat with Vivien about what's needed to be done here. I think the combination of you two is the best to figure out what needs to be done and who can do it.

Comment 4

[Axel Hecht [:Pike]]

I've talked to stas a bit, he's going to figure out what to do.

Thinking about it, if we want to use the mobile-cloned netError.xhtml, we probably need to use the mobile-derived netError.dtd.

This is unfortunate, as we may want to use non-branded error messages. Stas is gonna hack a bit to see how non-browser web apps may react to errors in remote content loading. If the errors show up there easily, we may not want to use "Firefox" branded UI. Stas is also going to talk to UX about this.

Comment 5

[Staś Małolepszy :stas]

I have this on my list for next week.

Comment 6

[Dietrich Ayala (:dietrich)]

Stas, now that we're string-frozen, can this be closed?

Comment 7

[Axel Hecht [:Pike]]

Sadly, not. with the patch in bug 796051 we get a better grip on how many files aren't actually used at all.

But there's still bits that I find confusing, like the crashreporter.ini.

Comment 8

[:Margaret Leibovic]

(In reply to Axel Hecht [:Pike] from comment #7)

> But there's still bits that I find confusing, like the crashreporter.ini.

I'm not sure why that file is included. It's definitely not used by the gaia crash reporter UI. I'm not familiar with the exact role of xulrunner in gaia, but it seems odd to me that crash reporter directories were included in there.

Comment 9

[Axel Hecht [:Pike]]

I'm actually just updating the patch in the chrome target bug to use strings in b2g, and in the course removing anything but neterror and appstrings.

Comment 10

[Damon Sicore (:damons)]

What's next here?

Comment 11

[Axel Hecht [:Pike]]

So far, nothing's blew up on us from bug 796051, thus I'll resolve this one as FIXED.

This is in collab with bug 808326, which nails down the branding questions within the remaining files.