796250 - Clock APP needs the ringtone media.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[GH to BZ]

[GitHub issue by ian-liu on 2012-07-11T06:50:38Z, https://github.com/mozilla-b2g/gaia/issues/2328]


STR:

    There is only one type of ringtone("classic.wav") when alarm on ringing.

Expected:

    It should have 2 or 3 kinds of ringtones to provide for user selection.

Actual:

    Only one ringtone.

Comment 1

[GH to BZ]

[GitHub comment by patrykdesign on 2012-07-13T17:45:21Z]
We have a vendor creating sounds, there should be media for this bug in mid to late August.

Comment 2

[GH to BZ]

[GitHub comment by dseixas on 2012-08-27T13:36:46Z]
Just a question out of interest, what file format should be used?

Comment 3

[GH to BZ]

[GitHub comment by patrykdesign on 2012-08-27T20:25:42Z]
@dseixas we should probably use WAV or MP3. MP3 would give us the best compatibility / size / quality bang for the buck

Comment 4

[GH to BZ]

[GitHub comment by patrykdesign on 2012-08-27T20:26:44Z]
@ian-liu try these out:
https://www.dropbox.com/s/t7k3btnk7t3uc4i/Alarms.zip

Please don't change the file names, I'll keep on sending you more as we refine and produce them.

Comment 5

[GH to BZ]

[GitHub comment by cgjones on 2012-08-27T21:57:59Z]
> dseixas we should probably use WAV or MP3. MP3 would give us the best compatibility / size / quality bang for the buck

Note, vorbis (ogg) generally has better quality per bitrate than mp3 (smaller files at the same quality), and it's additionally royalty- and license-free so there are no possible restrictions on us distributing or hosting the content.  We should prefer vorbis when possible.

Comment 6

[GH to BZ]

[GitHub comment by dseixas on 2012-08-28T09:09:06Z]
@patrykdesign Thanks for the info

Comment 7

[GH to BZ]

[GitHub comment by patrykdesign on 2012-08-30T12:47:56Z]
@cgjones I can get the vendor to export into any standard format, so we can get them as ogg. If its more performant, then I can do that for the final deliverable.

Comment 8

[GH to BZ]

[GitHub comment by cgjones on 2012-08-30T12:51:12Z]
Sounds great.

Comment 9

[GH to BZ]

[GitHub comment by cgjones on 2012-08-30T12:51:22Z]
(No pun intended.)

Comment 10

[GH to BZ]

[GitHub comment by ian-liu on 2012-09-04T10:57:45Z]
@cgjones 
I try to playback these media of .mp3 content.
I assign the path to src of audio tag as following:

var player = new Audio();
player.src='style/ringtones/ALARM_progressive_dapple.mp3';

But it can not be loaded.
Could we use .ogg to replace them?
Or I should to file a bug in this case.

=== Log ===
E/GeckoConsole( 1444): [JavaScript Warning: "HTTP "Content-Type" of "application/x-unknown-content-type" is not supported. Load of media resource app://clock.gaiamobile.org/style/ringtones/ALARM_progressive_dapple.mp3 failed." {file: "app://clock.gaiamobile.org/onring.html" line: 0}]

Comment 11

[GH to BZ]

[GitHub comment by ian-liu on 2012-09-04T17:54:44Z]
@cgjones 
I have file an issue for this case.
https://bugzilla.mozilla.org/show_bug.cgi?id=788204

@patrykdesign 
If we use mp3 format now, the implementation will be blocked by above issue.
Could we get the media as ogg for development?
I think it will speed up the feature completed.

Comment 12

[GH to BZ]

[GitHub comment by timdream on 2012-09-10T03:26:13Z]
Reassign to @patrykdesign

Comment 13

[GH to BZ]

[GitHub comment by ian-liu on 2012-09-13T08:53:27Z]
@patrykdesign 
Since the platform issue is landed, I have implemented the feature.
You could try to experience the feature when the pull request close.
I set the default ringtone to be "ALARM_progressive_dapple.mp3".
I won't refine the name of media until your feedback.
Thanks.

Comment 14

[GH to BZ]

[GitHub comment by patrykdesign on 2012-09-21T12:51:53Z]
@ian-liu I just emailed you some new alarms in OGG format. 
I do have a few comments about the alarm selection feature.
1. Once an alarm is selected it would be good to have a button in the alarm creation screen to test the sound.
2. During the alarm selection screen if a sound is too long, it should be truncated (ellipsis). We don't want to see horizontal scrolling in that list dialog

Comment 15

[Alex Keybl [:akeybl]]

[mass adding reproducible keyword for any open Gaia bug with the word "STR:" in comments]

Comment 16

[[e-mail], [e-mail]]

Hi Patryk,

I encounter platform issue to provide the latest ringtone patch.
These ogg files cannot be playback now.
But I have provided a test in UI Test APP.
You could launch UI Test APP --> audio tag tests --> Click specific media ringtone.
There are some specific ringtone which are provided by you.
We could test the ringtone after the issue fixed.
Bug 802044 - Can not playback when audio tag uses some specific *.ogg as src

Comment 17

[[e-mail], [e-mail]]

(In reply to GH to BZ from comment #14)
> [GitHub comment by patrykdesign on 2012-09-21T12:51:53Z]
> @ian-liu I just emailed you some new alarms in OGG format. 
> I do have a few comments about the alarm selection feature.
> 1. Once an alarm is selected it would be good to have a button in the alarm
> creation screen to test the sound.
Do you mean to have a button in alarm-edit page or the ringtone selector?

> 2. During the alarm selection screen if a sound is too long, it should be
> truncated (ellipsis). We don't want to see horizontal scrolling in that list
> dialog
For the issue, we will fix it after we confirm the name of ringtone.
BTW, we need to handle truncated issue for value selector.
Add Rudy in mail list.

Comment 18

[[e-mail], [e-mail]]

Depends on: Bug 799190 - [clock] alarm sound selections are not human readable, displayed as file names

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

According to comment 0 and the title this issue is fixed a long long time ago (we already have ringtones). Discussion regards how we represent those ringtones belongs to bug 799190 or another un-filed bug (need ringtone preview for ringtone selection on clock app).

Patryk, if you need the preview please file another bug, or ask Ian to do that.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

According to title this has no dependency to bug 802271.

Comment 21

[Rebecca Billings [:rbillings]]

Verified multiple ringtones available for alarms on the 11/12 otoro us build.