796499 - [settings] apn and mms settings have both "Back" and "OK" buttons

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[GH to BZ]

[GitHub issue by autonome on 2012-08-20T20:10:49Z, https://github.com/mozilla-b2g/gaia/issues/3606]
Should not have both, right? Also, back should be the standard icon, not a button with "back" text.

/cc @jcarpenter @lco

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

I don't agree that it's not logical to have both the Back and OK button in this screen. The back button acts as cancel (or should be) whilst the OK button persists the settings.

Comment 2

[Kevin Grandon :kgrandon]

What Jan said in Comment 1. We currently don't auto-save settings.

Comment 3

[Dietrich Ayala (:dietrich)]

We actually *do* auto-save settings throughout the *entire* Settings app except for here!

(There might be another screen like apn but I can't find one... there's a lot of surface area in this app)

The rest of Settings steadfastly convinces the user that they should make their changes and then hit the back button. Which means back == OK.

And then there's APN screen. Which does the opposite. Back == cancel, and OK == save.

Nice try engsplaining this one away guys, but I'll ni? UX and see what they have to say ;)

Comment 4

[Kevin Grandon :kgrandon]

I guess there is a larger question about consistency then. I'm not convinced it always makes sense to auto-save. I suppose it depends on the type of field and function.

We do not auto-save for:
Sound Ringer Selection
Sound Alert Selection
Bluetooth Device Naming
Hotspot Settings

It seems like checkbox-only screens are pretty much the only time we auto-save. I think we should still close this, and perhaps file another bug for consistency, but I'll let UX weigh in :)

Comment 5

[Dietrich Ayala (:dietrich)]

Hm, I don't think the problem is about making everything autosave vs mixed.

The problem is that it's ambiguous in the current UX whether a change is saved or not saved when you hit back in some places.

The consistency issue here is that Back sometimes means back+save and sometimes means back+cancel. Which are opposites.

Bluetooth device naming doesn't have this problem: The back button is replaced with an [x] button.

So far, the screens that have this issue:

* Cellular & Data -> Data Settings
* Cellular & Data -> Message Settings
* Cellular & Data -> A-GPS Settings
* Sound -> Ringer
* Sound -> Alerts
* Internet Sharing -> Hotspot settings

Comment 6

[Dietrich Ayala (:dietrich)]

See also bug 956518 for visual/interaction inconsistencies in this button model across the screens listed above.

Comment 7

[Stephany Wilkes]

Flagging both Neo (on the Settings side, which is critical here) and Casey, for the visual refresh/inconsistency aspects in the linked bug #956518. Let me know who would like to own this going forward.

Comment 8

[Neo Hsieh [:neo]]

According new building block design, we are suggesting the follwing rule:

1.Header with only back will save results when tapping back. 
2.Header with OK, Done button will not save result when tapping back. 
3.Page with editable field should use cancel header instead of back.

If any suggestions, please let us know.

Comment 9

[Dietrich Ayala (:dietrich)]

Thanks Neo!

However, this approach does not resolve the inconsistency that sometimes "back" results in save, and sometimes in "do not save".

I think is a real problem (especially in Settings!) because the same button and it's icon have *opposite* meanings, and it's not visually explicit that is the case.

In #2, can we also use cancel in place of the back button? This would resolve the ambiguity, and make the action explicit.

Comment 10

[Harly Hsu[:harly]]

Hi Dietrich,
I am the UX for the new building blocks design. I think what you've pointed out here does have some inconsistency issue, and the suggestion you provided will certainly solve the issue. I will modify the new building blocks design accordingly. Thanks

Comment 11

[[e-mail]]

supposedly 1.5 BB refresh should solve this issue?

Comment 12

[Bruce Huang [:bhuang] (inactive)]

Keeping it in backlog.

Comment 13

[Stephany Wilkes]

Removing flag for Casey since Harly has this.

Comment 14

[Jalpreet Singh Nanda [:imjalpreet]]

I want to take this bug up if it's free. If it's assigned to me, can you please tell what all changes need to be done.

Comment 15

[Dietrich Ayala (:dietrich)]

Changing ni? request to UX team to clearly describe the solution for this particular screen, so Jalpreet can work on it.

Comment 16

[Stephany Wilkes]

Flagging Jenny to advise, even though I realize this request may not make sense in the current context of "no 2.2" or "new 2.2". Thanks Jenny!

Comment 17

[Jalpreet Singh Nanda [:imjalpreet]]

What changes have to be done?

Comment 18

[Jenny Lee]

Hello all, 

For these cases the issue no longer exists: 
* Sound -> Ringer
* Sound -> Alerts
* Internet Sharing -> Hotspot settings

For these cases please refer to https://bug1032629.bugzilla.mozilla.org/attachment.cgi?id=8463205
for the header design change that resolves the issue.
* Cellular & Data -> Data Settings
* Cellular & Data -> Message Settings
* Cellular & Data -> A-GPS Settings

Thanks!

Comment 19

[Jalpreet Singh Nanda [:imjalpreet]]

Ok, Thanks. I will look into these.

Comment 20

[Jalpreet Singh Nanda [:imjalpreet]]

I am not able to see the Cellular and Data Settings option in the Settings as I am running firefox OS on the simulator as I don't have a hands-on firefox OS device. Is there any way I can make that setting visible?

Thanks!

Comment 21

[Dietrich Ayala (:dietrich)]

Hi Jalpreet!

You can test through desktop B2G or Mulet, as documented here: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Different_ways_to_run_Gaia#Using_Gaia_in_Firefox_Mulet

Comment 22

[BMO Automation]

Firefox OS is not being worked on