796509 - [phone] Need an asset for 'Airplane Mode' dialog when emiting a call while the phone is in airplane mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[GH to BZ]

[GitHub issue by patrykdesign on 2012-08-22T12:36:41Z, https://github.com/mozilla-b2g/gaia/issues/3695]

Comment 1

[GH to BZ]

[GitHub comment by authoritaire on 2012-08-22T13:04:59Z]
Surely this would be a prompt dialogue box, explaining you need to disable airplane mode to make the call. see building blocks/ dialogues/ prompts. cheers s_

Comment 2

[GH to BZ]

[GitHub comment by oteo on 2012-08-22T16:08:33Z]
According to the last version of the Dialer WF: https://wiki.mozilla.org/images/2/29/HTML5_Dialer_Contacts_20120810_R2S1_V6.0.pdf

If flight safe mode is on opened wireframe ‘confirmation dialogue’ and populate dialogue with:
- title: “Flight Safe Mode Activated”
- body: “In order to make a call, you must first disable Flight Safe Mode”
- buttons: “OK” (closes the dialogue and returns the user to wireframe ‘dialer’ with the dialed number still populated in the number field)

Comment 3

[GH to BZ]

[GitHub comment by oteo on 2012-08-22T16:14:44Z]
http://telefonicaid.github.com/Gaia-UI-Building-Blocks/index.html#menus-dialogues/prompt/
can be reused for it

Comment 4

[GH to BZ]

[GitHub comment by authoritaire on 2012-09-05T14:54:36Z]
Yes these prompts can be used for it. Note it is best to go to moz share
Dropbox/OWD_Moz_share/_Production/Building Blocks/01 Menus + Dialogues/01 Prompt/OWD_01_Prompt_Default.png

as the telefonicaid needs to be updated (ismael is aware of this and planning to update the CSS asap). so use the above link. cheers

Comment 5

[GH to BZ]

[GitHub comment by autonome on 2012-09-10T15:46:07Z]
would like this, but not holding V1 release on it. the existing prompt is ok for now.

Comment 6

[Victoria Gerchinhoren [:vicky]]

Please use this design:
https://www.dropbox.com/s/9r1iwp8ud2huj2i/OWD_00_airplanemode.png

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

It is a consequence of the deletion of the CustomDialog JS file :-) I am deleting any CustomDialog use in the Communications app and substituting it with the proper BBs components ;-) I'll keep you posted.

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

In fact, it also happens if the user tries to make a call with no SIM card (no error message is shown). Fixing it too! ;-)

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Related PR link: https://github.com/mozilla-b2g/gaia/pull/6360

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR diff file.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

:gtorodelvalle is the attachment obsolete?

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Current Airplane mode screen.

This is the message currently shown to the user. Should I updated to the text mentioned by GH above?

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Ups, I just saw Victoria's comment. Updating it to what she mentions in her comment: https://www.dropbox.com/s/9r1iwp8ud2huj2i/OWD_00_airplanemode.png

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated new PR.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 686126 [details] [diff] [review]
Associated new PR.

German, any change that implies modifying any string *must* be reviewed by Stas

Thanks!

Comment 16

[Staś Małolepszy :stas]

Comment on attachment 686126 [details] [diff] [review]
Associated new PR.

r=me on the localization part, well done.

Comment 17

[Germán Toro del Valle (:gtorodelvalle)]

- PR https://github.com/mozilla-b2g/gaia/pull/6687 landed in Gaia.

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 686126 [details] [diff] [review]
Associated new PR.

Please don't merge next time until you get the bb+ OR the gaia master approval.

Thanks.

Comment 19

[Germán Toro del Valle (:gtorodelvalle)]

Ups, my bad!!! I was checking tons of bugs and sincerely I thought I saw the +, but definitely it was on other bug... ;-999 Thanks!