796721 - Youtube videos displayed are not scaled properly - clipped on the right side

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[GH to BZ]

[GitHub issue by daleharvey on 2012-09-25T01:02:31Z, https://github.com/mozilla-b2g/gaia/issues/5115]

Comment 1

[GH to BZ]

[GitHub comment by autonome on 2012-09-28T16:20:59Z]
Need screenshot and STR.

Comment 2

[GH to BZ]

[GitHub comment by jammink on 2012-10-01T15:27:39Z]
I'll try to get a screenshot here.  When I tried to access youtube.com, I see that a large portion of the video window is cut off the the right side.

I'm unable to get a screenshot :-/

Comment 3

[GH to BZ]

[GitHub comment by daleharvey on 2012-10-01T15:30:49Z]
Just to clarify the problem, when launching youtube videos the player size isnt correctly set to only a small portion of the video will be viewable and the ui in general will be broken (I would probably call it a blocking+)

Comment 4

[GH to BZ]

[GitHub comment by jammink on 2012-10-01T15:46:30Z]
Got the screenshot, finally: http://imgur.com/8Re14

Comment 5

[Jason Smith [:jsmith]]

FF Android Evangelism is going to become a graveyard component soon - please use Tech Evangelism --> Mobile.

Comment 6

[Jason Smith [:jsmith]]

Wait a second....this needs more information before concluding if it's evangelism or not. 

The way we handle youtube videos on FF OS is that when a user clicks a video, it opens the video in the video app, then we view the video in there. The gaia issue cited it as a "video" app bug, but the screenshot above implies the problem is on the youtube side.

Dale - Can you clarify?

Comment 7

[Dale Harvey (:daleharvey)]

An update, during triage and the screenshot this was confused as the wrong bug, the bug with the play button being cropped (seen in the screenshot), is a bug on youtubes side.

This bug is the fact the actual videos when played themselves are scaled incorrectly

Comment 8

[Chris Lee [:clee]]

Marking as blocking to get YouTube videos to play properly.

Comment 10

[Dale Harvey (:daleharvey)]

Attachment: Ensure videos from youtube are scaled correctly

Comment 11

[David Flanagan [:djf]]

Comment on attachment 676831 [details]
Ensure videos from youtube are scaled correctly

r+, but I worry that the code is a little brittle. See the suggestions on github.

Comment 12

[Dale Harvey (:daleharvey)]

fixed in: https://github.com/mozilla-b2g/gaia/commit/c7a781cc16992ddb3f890ef3d1db673e8e25ab6f

Comment 13

[Deepa Subramanian]

Unable to play a video from http://m.youtube.com to verify the video is scaled correctly

Comment 14

[Jason Smith [:jsmith]]

(In reply to Deepa Subramanian from comment #13)
> Unable to play a video from http://m.youtube.com to verify the video is
> scaled correctly

There's already a bug open on that.

Comment 15

[J Zimbrick]

Issue no longer appears to be occurring in Unagi build 20130112070202.

Youtube videos play and seem to be scaling properly.

Verifying as fixed.