796887 - New Win8 related registry cache entries

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Jim Mathies [:jimm]]

Keys we need to investigate and potentially reset on install / set as default, and maybe delete on uninstall.

Comment 1

[Jim Mathies [:jimm]]

HKEY_CLASSES_ROOT\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\SplashScreen\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

EEFEA8717BC47F65 is the app id. This area contains cached information on our metro plash screen.

HKEY_CLASSES_ROOT\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\PersistedPickerData\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

HKEY_CURRENT_USER\Software\Classes\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\PersistedPickerData\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

File picker state.

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\SearchHistory\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

Search history

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\ApplicationAssociationToasts
"FirefoxHTML_.htm"=-
"FirefoxHTML_.html"=-
"FirefoxHTML_.xht"=-
"FirefoxHTML_.xhtml"=-
"FirefoxURL_ftp"=-
"FirefoxURL_http"=-
"FirefoxURL_https"=-

Related to toasts for file and protocol associates.

Comment 2

[Jim Mathies [:jimm]]

> HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\ApplicationAssoci
> ationToasts
> "FirefoxHTML_.htm"=-
> "FirefoxHTML_.html"=-
> "FirefoxHTML_.xht"=-
> "FirefoxHTML_.xhtml"=-
> "FirefoxURL_ftp"=-
> "FirefoxURL_http"=-
> "FirefoxURL_https"=-
> 
> Related to toasts for file and protocol associates.

Blowing these away appears to reset the first install toast.

Comment 3

[Brian R. Bondy [:bbondy]]

Sweet, that would be great to display the flyout on each install.

Comment 4

[Jim Mathies [:jimm]]

Attachment: splash and flyout settings v.1

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 666984 [details] [diff] [review]
splash and flyout settings v.1

Switching over so we can get this in the uninstall for easier testing. Rob if you see something here you don't like please chime in.

Comment 6

[Brian R. Bondy [:bbondy]]

Comment on attachment 666984 [details] [diff] [review]
splash and flyout settings v.1

Review of attachment 666984 [details] [diff] [review]:
-----------------------------------------------------------------

The other Metro registration is done in common.nsh with passing in values.  That way it can be re-used by other products like seamonkey if they choose to.
But I'm fine with us doing that refactoring when/if it is needed.

::: browser/installer/windows/nsis/installer.nsi
@@ +304,5 @@
>  
>    ; setup the application model id registration value
>    ${InitHashAppModelId} "$INSTDIR" "Software\Mozilla\${AppName}\TaskBarIDs"
>  
> +  ${ResetWin8MetroSplash}

nit:
!ifdef MOZ_METRO
  ${ResetWin8MetroSplash}
!endif

::: browser/installer/windows/nsis/shared.nsh
@@ +703,5 @@
> +  ${AndIf} "$AppUserModelID" != ""
> +    DeleteRegKey HKCR "Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\SplashScreen\DefaultBrowser_NOPUBLISHERID!$AppUserModelID"
> +  ${EndIf}
> +!macroend
> +!define ResetWin8MetroSplash "!insertmacro ResetWin8MetroSplash"

nit: around the whole ResetWin8MetroSplash
!ifdef MOZ_METRO
...
!endif

::: browser/installer/windows/nsis/uninstaller.nsi
@@ +294,5 @@
>    ${EndIf}
>  !endif
>  
> +  ${ResetWin8PromptKeys}
> +  ${ResetWin8MetroSplash}

nit:

${ResetWin8PromptKeys}
!ifdef MOZ_METRO
  ${ResetWin8MetroSplash}
!endif

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/b013e02c3c9d

Comment 8

[Jim Mathies [:jimm]]

https://hg.mozilla.org/mozilla-central/rev/32ba7924b04c