Closed Bug 796887 Opened 12 years ago Closed 12 years ago

New Win8 related registry cache entries

Categories

(Firefox :: Shell Integration, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [metro-mvp][LOE:-])

Attachments

(1 file)

Keys we need to investigate and potentially reset on install / set as default, and maybe delete on uninstall.
HKEY_CLASSES_ROOT\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\SplashScreen\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

EEFEA8717BC47F65 is the app id. This area contains cached information on our metro plash screen.

HKEY_CLASSES_ROOT\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\PersistedPickerData\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

HKEY_CURRENT_USER\Software\Classes\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\PersistedPickerData\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

File picker state.

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\SearchHistory\DefaultBrowser_NOPUBLISHERID!EEFEA8717BC47F65

Search history

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\ApplicationAssociationToasts
"FirefoxHTML_.htm"=-
"FirefoxHTML_.html"=-
"FirefoxHTML_.xht"=-
"FirefoxHTML_.xhtml"=-
"FirefoxURL_ftp"=-
"FirefoxURL_http"=-
"FirefoxURL_https"=-

Related to toasts for file and protocol associates.
> HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\ApplicationAssoci
> ationToasts
> "FirefoxHTML_.htm"=-
> "FirefoxHTML_.html"=-
> "FirefoxHTML_.xht"=-
> "FirefoxHTML_.xhtml"=-
> "FirefoxURL_ftp"=-
> "FirefoxURL_http"=-
> "FirefoxURL_https"=-
> 
> Related to toasts for file and protocol associates.

Blowing these away appears to reset the first install toast.
Assignee: nobody → jmathies
Sweet, that would be great to display the flyout on each install.
Whiteboard: [leave open]
Attachment #666984 - Flags: review?(robert.bugzilla)
Whiteboard: [leave open] → [leave open], metro-beta
Whiteboard: [leave open], metro-beta → [leave open], [metro-mvp]
Comment on attachment 666984 [details] [diff] [review]
splash and flyout settings v.1

Switching over so we can get this in the uninstall for easier testing. Rob if you see something here you don't like please chime in.
Attachment #666984 - Flags: review?(robert.bugzilla) → review?(netzen)
Comment on attachment 666984 [details] [diff] [review]
splash and flyout settings v.1

Review of attachment 666984 [details] [diff] [review]:
-----------------------------------------------------------------

The other Metro registration is done in common.nsh with passing in values.  That way it can be re-used by other products like seamonkey if they choose to.
But I'm fine with us doing that refactoring when/if it is needed.

::: browser/installer/windows/nsis/installer.nsi
@@ +304,5 @@
>  
>    ; setup the application model id registration value
>    ${InitHashAppModelId} "$INSTDIR" "Software\Mozilla\${AppName}\TaskBarIDs"
>  
> +  ${ResetWin8MetroSplash}

nit:
!ifdef MOZ_METRO
  ${ResetWin8MetroSplash}
!endif

::: browser/installer/windows/nsis/shared.nsh
@@ +703,5 @@
> +  ${AndIf} "$AppUserModelID" != ""
> +    DeleteRegKey HKCR "Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\SystemAppData\DefaultBrowser_NOPUBLISHERID\SplashScreen\DefaultBrowser_NOPUBLISHERID!$AppUserModelID"
> +  ${EndIf}
> +!macroend
> +!define ResetWin8MetroSplash "!insertmacro ResetWin8MetroSplash"

nit: around the whole ResetWin8MetroSplash
!ifdef MOZ_METRO
...
!endif

::: browser/installer/windows/nsis/uninstaller.nsi
@@ +294,5 @@
>    ${EndIf}
>  !endif
>  
> +  ${ResetWin8PromptKeys}
> +  ${ResetWin8MetroSplash}

nit:

${ResetWin8PromptKeys}
!ifdef MOZ_METRO
  ${ResetWin8MetroSplash}
!endif
Attachment #666984 - Flags: review?(netzen) → review+
Whiteboard: [leave open], [metro-mvp] → [leave open], [metro-mvp] [LOE:-]
Whiteboard: [leave open], [metro-mvp] [LOE:-] → [leave open][metro-mvp][LOE:-]
Whiteboard: [leave open][metro-mvp][LOE:-] → [metro-mvp][LOE:-]
Depends on: elm-merge
Blocks: elm-merge
No longer depends on: elm-merge
https://hg.mozilla.org/mozilla-central/rev/32ba7924b04c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: