Update updater strings and icon

VERIFIED FIXED in Firefox 17

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: snorp, Assigned: snorp)

Tracking

({productwanted})

unspecified
Firefox 18
ARM
Android
productwanted
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed, firefox18 verified)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Design has come up with new strings and icon(s) for the updater, so we need to get that in.
Assignee: nobody → snorp
Created attachment 667072 [details] [diff] [review]
Add new updater strings and icons on Android
Attachment #667072 - Flags: review?(blassey.bugs)
Blocks: 797039
Created attachment 667092 [details] [diff] [review]
Add new updater strings and icons on Android
Attachment #667092 - Flags: review?(sriram)
Attachment #667072 - Attachment is obsolete: true
Attachment #667072 - Flags: review?(blassey.bugs)
Comment on attachment 667092 [details] [diff] [review]
Add new updater strings and icons on Android

Review of attachment 667092 [details] [diff] [review]:
-----------------------------------------------------------------

The icons look good to me.
Attachment #667092 - Flags: review?(sriram) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/25a38fc220d6
https://hg.mozilla.org/mozilla-central/rev/25a38fc220d6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Sorry but you can't change strings and keep the original entity name, this patch shouldn't have passed review

https://hg.mozilla.org/mozilla-central/diff/25a38fc220d6/mobile/android/base/locales/en-US/android_strings.dtd
Changes were applied on the latest Nightly build. Also the new update icon is really nice! Closing bug as verified fixed.

--
Firefox 18.0a1 (2012-10-05)
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18: --- → verified
Created attachment 668626 [details] [diff] [review]
Bump string version numbers
Attachment #668626 - Flags: review?(mark.finkle)
Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

Thanks
Attachment #668626 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/107c60f2d45a
https://hg.mozilla.org/mozilla-central/rev/107c60f2d45a
(In reply to Ed Morley [:edmorley UTC+1] from comment #11)
> https://hg.mozilla.org/mozilla-central/rev/107c60f2d45a

This part landed on mozilla19.
Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

[Approval Request Comment]
I think we'll want this in order to have l10n for the updater on aurora
Attachment #668626 - Flags: approval-mozilla-aurora?
Given this breaks string freeze, I think it makes sense to just ship it as part of FF19 and back out whatever changes made it into FF18. This isn't a user-facing feature for FF18 outside of our test channels anyway. Thoughts?
(In reply to Alex Keybl [:akeybl] from comment #14)
> Given this breaks string freeze, I think it makes sense to just ship it as
> part of FF19 and back out whatever changes made it into FF18. This isn't a
> user-facing feature for FF18 outside of our test channels anyway. Thoughts?

Adding product-wanted because product wants to ship to alternative app stores, which will require this
Keywords: productwanted
Alex, this change is to make the string changes that are in the product actually be exposed as such on the dashboard. I'm not sure if we wanted to half of this patch having the localization for this patch, and half of it for the previous code path.

I suggest to take this.
We need this updater to get going on Appia as an alternate distribution channel so we can ultimately start extending our reach - the more we wait on this, the longer it's going to take to get more users. This should be a fairly easy win for us to get more exposure through a different channel, so I'd like to see this implemented asap.
(In reply to Karen Rudnitski from comment #17)
> We need this updater to get going on Appia as an alternate distribution
> channel so we can ultimately start extending our reach - the more we wait on
> this, the longer it's going to take to get more users. This should be a
> fairly easy win for us to get more exposure through a different channel, so
> I'd like to see this implemented asap.

Karen, what version do you plan to ship to Appia?
I was expecting whatever version we were about to GA once the release process is locked down and agreement signed (which was dependent on this updater work).

Irina, how quickly can that agreement be signed knowing the ToS have already been cleared? Who in bus dev is leading this deal?
Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

snorp - land ASAP so l10n has ample time.
Attachment #668626 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 774497
Depends on: 796102
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7e0f2dd4a6d
Comment on attachment 667092 [details] [diff] [review]
Add new updater strings and icons on Android

[Approval Request Comment]
Updates UI and strings to what we have in Aurora/Trunk. Low risk, but does include string changes.
Attachment #667092 - Flags: approval-mozilla-beta?
Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

[Approval Request Comment]
Required by the above patch
Attachment #668626 - Flags: approval-mozilla-beta?
Attachment #667092 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

approving for uplift given comment 16
Attachment #668626 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/4fef2883f202
https://hg.mozilla.org/releases/mozilla-beta/rev/d7404977cb9c

Updated

5 years ago
status-firefox17: --- → fixed
Someone should really explain to me how we moved from "take this for FF18" (comment 16 means that, as far as I understand it) to "let's break betas".
You need to log in before you can comment on or make changes to this bug.