797036 - Update updater strings and icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Design has come up with new strings and icon(s) for the updater, so we need to get that in.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add new updater strings and icons on Android

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add new updater strings and icons on Android

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 667092 [details] [diff] [review]
Add new updater strings and icons on Android

Review of attachment 667092 [details] [diff] [review]:
-----------------------------------------------------------------

The icons look good to me.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25a38fc220d6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25a38fc220d6

Comment 6

[Francesco Lodolo [:flod]]

Sorry but you can't change strings and keep the original entity name, this patch shouldn't have passed review

https://hg.mozilla.org/mozilla-central/diff/25a38fc220d6/mobile/android/base/locales/en-US/android_strings.dtd

Comment 7

[Cristian Nicolae (:xti)]

Changes were applied on the latest Nightly build. Also the new update icon is really nice! Closing bug as verified fixed.

--
Firefox 18.0a1 (2012-10-05)
Device: Galaxy Note
OS: Android 4.0.4

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bump string version numbers

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

Thanks

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/107c60f2d45a

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/107c60f2d45a

Comment 12

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley UTC+1] from comment #11)
> https://hg.mozilla.org/mozilla-central/rev/107c60f2d45a

This part landed on mozilla19.

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

[Approval Request Comment]
I think we'll want this in order to have l10n for the updater on aurora

Comment 14

[Alex Keybl [:akeybl]]

Given this breaks string freeze, I think it makes sense to just ship it as part of FF19 and back out whatever changes made it into FF18. This isn't a user-facing feature for FF18 outside of our test channels anyway. Thoughts?

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Alex Keybl [:akeybl] from comment #14)
> Given this breaks string freeze, I think it makes sense to just ship it as
> part of FF19 and back out whatever changes made it into FF18. This isn't a
> user-facing feature for FF18 outside of our test channels anyway. Thoughts?

Adding product-wanted because product wants to ship to alternative app stores, which will require this

Comment 16

[Axel Hecht [:Pike]]

Alex, this change is to make the string changes that are in the product actually be exposed as such on the dashboard. I'm not sure if we wanted to half of this patch having the localization for this patch, and half of it for the previous code path.

I suggest to take this.

Comment 17

[Karen Rudnitski [:kar]]

We need this updater to get going on Appia as an alternate distribution channel so we can ultimately start extending our reach - the more we wait on this, the longer it's going to take to get more users. This should be a fairly easy win for us to get more exposure through a different channel, so I'd like to see this implemented asap.

Comment 18

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Karen Rudnitski from comment #17)
> We need this updater to get going on Appia as an alternate distribution
> channel so we can ultimately start extending our reach - the more we wait on
> this, the longer it's going to take to get more users. This should be a
> fairly easy win for us to get more exposure through a different channel, so
> I'd like to see this implemented asap.

Karen, what version do you plan to ship to Appia?

Comment 19

[Karen Rudnitski [:kar]]

I was expecting whatever version we were about to GA once the release process is locked down and agreement signed (which was dependent on this updater work).

Irina, how quickly can that agreement be signed knowing the ToS have already been cleared? Who in bus dev is leading this deal?

Comment 20

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

snorp - land ASAP so l10n has ample time.

Comment 21

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7e0f2dd4a6d

Comment 22

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 667092 [details] [diff] [review]
Add new updater strings and icons on Android

[Approval Request Comment]
Updates UI and strings to what we have in Aurora/Trunk. Low risk, but does include string changes.

Comment 23

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

[Approval Request Comment]
Required by the above patch

Comment 24

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 668626 [details] [diff] [review]
Bump string version numbers

approving for uplift given comment 16

Comment 25

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4fef2883f202
https://hg.mozilla.org/releases/mozilla-beta/rev/d7404977cb9c

Comment 26

[Francesco Lodolo [:flod]]

Someone should really explain to me how we moved from "take this for FF18" (comment 16 means that, as far as I understand it) to "let's break betas".