797049 - Disable C4351 when compiling with MSVC, sync up disabled warnings between configure.in and js/src/configure.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

C4351 warns for this case:

  struct S
  {
    char a[5];
    S() : a() { }
  };

and specifically for the |a()|, which since MSVC 2005 will default-initialize |a|.  That's the standard behavior, and JS has code which expects it, so we should just disable this warning.

I also took the opportunity to slightly clean up the disabled-warnings list for MSVC in both configure scripts.

There's one other warning that JS disables that isn't disabled in the overall configure, but I think it was a mistake to disable C4244, so I'm not adding it right now, and I'd actually like to un-disable it in JS and fix the cases where we hit it.

With this patch compiling the JS shell is again warning-free on Windows in opt builds.

Comment 1

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c15883431cbb

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c15883431cbb