802352 - Port |Bug 797049 - Disable C4351 as an MSVC warning about a change to be standards-compliant in MSVC2005 (!). Also sync up warning-disabling between configure.in and js/src/configure.in, and add comments about the warnings being disabled| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ian Neal]

Mozilla-central did some fixes around warnings when using MSVC, these should probably be ported to comm-central, see bug 797049 for more details.

Comment 1

[Ian Neal]

Could look at, as part of this, porting:
Bug 786579 - Remove old MSVC (<=2003) support

Comment 2

[Ian Neal]

Probably should also port:
Bug 665969 - Make C4553 fatal

Comment 3

[Ian Neal]

Attachment: Combo port patch [Checked in: Comment 6]

I will push this patch and the one from bug 802343 to the try server

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 673582 [details] [diff] [review]
Combo port patch [Checked in: Comment 6]

Review of attachment 673582 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1927,5 @@
> +        # that behavior) that it's better to turn it off.
> +        CXXFLAGS="$CXXFLAGS -wd4345 -wd4351 -wd4800"
> +        # make 'foo == bar;' error out
> +        CFLAGS="$CFLAGS -we4553"
> +        CXXFLAGS="$CXXFLAGS -we4553"

I would only caution that this (-we4553) *could* bust something in our tree when it lands. Please keep an eye out for that. If it does bust something it is a bug we should fix though.

(I don't see any comments here about the results of that try run)

Comment 5

[Mozilla RelEng Bot]

Try run for 0ed550f1084b is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0ed550f1084b
Results (out of 11 total builds):
    success: 9
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0ed550f1084b

Comment 6

[Ian Neal]

Comment on attachment 673582 [details] [diff] [review]
Combo port patch [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/5360b5193337