Closed
Bug 802352
Opened 12 years ago
Closed 12 years ago
Port |Bug 797049 - Disable C4351 as an MSVC warning about a change to be standards-compliant in MSVC2005 (!). Also sync up warning-disabling between configure.in and js/src/configure.in, and add comments about the warnings being disabled| to comm-central
Categories
(MailNews Core :: Build Config, defect)
Tracking
(seamonkey2.16 fixed)
RESOLVED
FIXED
Thunderbird 19.0
| Tracking | Status | |
|---|---|---|
| seamonkey2.16 | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
4.96 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Mozilla-central did some fixes around warnings when using MSVC, these should probably be ported to comm-central, see bug 797049 for more details.
Could look at, as part of this, porting: Bug 786579 - Remove old MSVC (<=2003) support
Probably should also port: Bug 665969 - Make C4553 fatal
I will push this patch and the one from bug 802343 to the try server
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #673582 -
Flags: review?(bugspam.Callek)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 673582 [details] [diff] [review] Combo port patch [Checked in: Comment 6] Review of attachment 673582 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +1927,5 @@ > + # that behavior) that it's better to turn it off. > + CXXFLAGS="$CXXFLAGS -wd4345 -wd4351 -wd4800" > + # make 'foo == bar;' error out > + CFLAGS="$CFLAGS -we4553" > + CXXFLAGS="$CXXFLAGS -we4553" I would only caution that this (-we4553) *could* bust something in our tree when it lands. Please keep an eye out for that. If it does bust something it is a bug we should fix though. (I don't see any comments here about the results of that try run)
Attachment #673582 -
Flags: review?(bugspam.Callek) → review+
|
||
Comment 5•12 years ago
|
||
Try run for 0ed550f1084b is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=0ed550f1084b
Results (out of 11 total builds):
success: 9
warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/iann_cvs@blueyonder.co.uk-0ed550f1084bComment on attachment 673582 [details] [diff] [review] Combo port patch [Checked in: Comment 6] http://hg.mozilla.org/comm-central/rev/5360b5193337
Attachment #673582 -
Attachment description: Combo port patch → Combo port patch [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-seamonkey2.16:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in
before you can comment on or make changes to this bug.
Description
•