Port |Bug 797049 - Disable C4351 as an MSVC warning about a change to be standards-compliant in MSVC2005 (!). Also sync up warning-disabling between configure.in and js/src/configure.in, and add comments about the warnings being disabled| to comm-central

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
Thunderbird 19.0
x86
Windows XP
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Mozilla-central did some fixes around warnings when using MSVC, these should probably be ported to comm-central, see bug 797049 for more details.
(Assignee)

Comment 1

5 years ago
Could look at, as part of this, porting:
Bug 786579 - Remove old MSVC (<=2003) support
(Assignee)

Comment 2

5 years ago
Probably should also port:
Bug 665969 - Make C4553 fatal
(Assignee)

Updated

5 years ago
Blocks: 803854
(Assignee)

Comment 3

5 years ago
Created attachment 673582 [details] [diff] [review]
Combo port patch [Checked in: Comment 6]

I will push this patch and the one from bug 802343 to the try server
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #673582 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

5 years ago
Depends on: 803856
(Assignee)

Updated

5 years ago
Depends on: 803862
Comment on attachment 673582 [details] [diff] [review]
Combo port patch [Checked in: Comment 6]

Review of attachment 673582 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +1927,5 @@
> +        # that behavior) that it's better to turn it off.
> +        CXXFLAGS="$CXXFLAGS -wd4345 -wd4351 -wd4800"
> +        # make 'foo == bar;' error out
> +        CFLAGS="$CFLAGS -we4553"
> +        CXXFLAGS="$CXXFLAGS -we4553"

I would only caution that this (-we4553) *could* bust something in our tree when it lands. Please keep an eye out for that. If it does bust something it is a bug we should fix though.

(I don't see any comments here about the results of that try run)
Attachment #673582 - Flags: review?(bugspam.Callek) → review+

Comment 5

5 years ago
Try run for 0ed550f1084b is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0ed550f1084b
Results (out of 11 total builds):
    success: 9
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/iann_cvs@blueyonder.co.uk-0ed550f1084b
(Assignee)

Comment 6

5 years ago
Comment on attachment 673582 [details] [diff] [review]
Combo port patch [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/5360b5193337
Attachment #673582 - Attachment description: Combo port patch → Combo port patch [Checked in: Comment 6]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-seamonkey2.16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.