797134 - Right-clicking on the Social API ambient notification buttons opens the panel and context menu

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The mousedown handler for the ambient notification buttons should check for e.button==0 to make sure that this was not a right-click on the button.

Comment 1

[scaraveo]

Attachment: mouse.patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 667634 [details] [diff] [review]
mouse.patch

Review of attachment 667634 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +613,5 @@
>          let box = document.createElement("box");
>          box.classList.add("toolbarbutton-1");
>          box.setAttribute("id", iconId);
> +        box.addEventListener("mousedown", function (e) {
> +          if (e.button == 0) SocialToolbar.showAmbientPopup(box);

Place |SocialToolbar.showAmbientPopup(box);| on its own line.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: mouse.patch

feedback change.  carry forward r+

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fca620575ce

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1fca620575ce

Shane, can you please add your email address to your hg user info?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e81f0d6ac4f9

Comment 7

[Virgil Dicu [:virgil] [QA]]

Reproduced in 2012-10-02 Firefox Nightly 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0
Build ID: 20121002030526
for the MoTown Social API available for this Nightly.

For the
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 Beta 5
Build ID: 20121106195758
for both MoTown and Facebook Social API, right-clicking the notification buttons are show only the context menu.

Comment 8

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old