Closed Bug 797134 Opened 7 years ago Closed 7 years ago

Right-clicking on the Social API ambient notification buttons opens the panel and context menu

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(firefox17+ verified)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 + verified

People

(Reporter: jaws, Assigned: mixedpuppy)

Details

(Whiteboard: [Fx17])

Attachments

(1 file, 1 obsolete file)

The mousedown handler for the ambient notification buttons should check for e.button==0 to make sure that this was not a right-click on the button.
Attached patch mouse.patch (obsolete) — Splinter Review
Assignee: nobody → scaraveo
Attachment #667634 - Flags: review?(jaws)
Assignee: scaraveo → mixedpuppy
Comment on attachment 667634 [details] [diff] [review]
mouse.patch

Review of attachment 667634 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +613,5 @@
>          let box = document.createElement("box");
>          box.classList.add("toolbarbutton-1");
>          box.setAttribute("id", iconId);
> +        box.addEventListener("mousedown", function (e) {
> +          if (e.button == 0) SocialToolbar.showAmbientPopup(box);

Place |SocialToolbar.showAmbientPopup(box);| on its own line.
Attachment #667634 - Flags: review?(jaws) → review+
Attachment #667634 - Flags: approval-mozilla-aurora+
Attached patch mouse.patchSplinter Review
feedback change.  carry forward r+
Attachment #667634 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1fca620575ce

Shane, can you please add your email address to your hg user info?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #667642 - Flags: approval-mozilla-aurora+
Reproduced in 2012-10-02 Firefox Nightly 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0
Build ID: 20121002030526
for the MoTown Social API available for this Nightly.

For the
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 Beta 5
Build ID: 20121106195758
for both MoTown and Facebook Social API, right-clicking the notification buttons are show only the context menu.
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.