797165 - [keyboard] discard suggestions when the user moves the cursor

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[David Flanagan [:djf]]

When the keyboard is displaying suggestions and the user moves the cursor, the suggestions should disappear and the prediction engine should reset its state to match the new cursor position.

Comment 1

[David Flanagan [:djf]]

Renominating this.  There are five text prediction bugs that I nominated. All must block or all must not block.  Three have been blocking+, one isn't decided yet, and this one got minused.  

It makes no sense for me to fix the other blocking bugs and leave this one unfixed. The keyboard predictions would still be unusable, and we'd have to remove them from v1.

This must block, or 797176, 797179 and 797182 must be marked blocking-. There is no other choice.  

This would be much simpler if I could just nominate the meta bug.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Josh - Can you give some UX viewpoint on the blocking nature of the bug?

Comment 3

[David Flanagan [:djf]]

This bug is just a note to myself about somethign that is really broken with text prediction.  I didn't write it to be debated by committee.  But really, it needs to block.  Please take my word.

Or I can just close it and fix this part of predictive text as part of some other bug.

I regret the day I ever created a metabug for predictive text.  The bug is that predictive text input is completely unusable and needs to be fixed. Please just let me fix the damn bugs!

Okay rant off, but this is really getting ridiculous.

We don't need Josh's input for this.  This bug addresses the following:

- turn on text predictions
- type few words like "this is a tes"
- at this point the keyboard is offering you suggestions for completing "tes".  Words like "test", for example.
- now tap in the input field to move the cursor, placing it inside of the word "this" for example
- the keyboard still offers you the completion "tes"

That is so broken that it needs to be fixed or we need to disable predictions entirely.  Its trivial to fix.  I just need the damn blocking flag, please.  I've been asking for it for over a week, and this has been through triage twice already.  This is a really inefficient process.

I'm clearing the needinfo request because we don't need to waste josh's time on this.

Comment 4

[Dylan Oliver [:doliver]]

Marking blocking+ -- 4 of the other 5 bugs are blocking so we've already decided we need predictive text and :djf says this is integral to the feature.

Comment 5

[David Flanagan [:djf]]

fixed by https://github.com/mozilla-b2g/gaia/pull/6007