797155 - [keyboard] enable word suggestions/predictions by default

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

Predictive text is a key feature for any mobile virtual keyboard, and is pretty important to have for dogfooding. Currently, word suggestions are too broken to enable by default.

This is an umbrella bug for all the fixes that need to happen before we can turn suggestions on by default.

I'd like to consider this a continuation of https://github.com/mozilla-b2g/gaia/issues/2814, which is the only open bug on github about keyboard predictions.

I will nominate this as blocking basecamp because that bug on github was blocking+.

Comment 1

[Dietrich Ayala (:dietrich)]

I don't think this blocks, but needs to land anyway. a=me (aka, you have approval to land it)

Comment 2

[Dietrich Ayala (:dietrich)]

Once it lands, please file a bug for disabling it and request blocking on that one.

Comment 3

[Dietrich Ayala (:dietrich)]

Re-evaluating - thanks for the ping David. We don't block on meta-bugs, so removing the blocking flag.

For the child bugs here, please nominate the ones you think block our ability to ship the release with this feature in it.

Comment 4

[David Flanagan [:djf]]

Thanks Dietrich! I've nominated a bunch (but not all) of the child bugs.

Comment 5

[David Flanagan [:djf]]

I've nominated child bugs #797165, #797176, #797179, #797182, #799013 as blocking.
In my opinion all five of these bugs must be fixed or predictive text will be too broken to enable.

So we must either mark all five blocking, or we must file a new (blocking) bug to remove the predictive text feature. It is not enough to leave it off-by-default as it is now.

I'll mark each of these five nominated bugs as LOE:S.

Comment 6

[Andreas Gal :gal]

Who is owning this work? Who is working on it this second? Is that you?

Comment 7

[David Flanagan [:djf]]

I've assigned all these bugs to myself, and my plan is to work on that, though I've been advised that I should not do that unless and until they get marked blocking+

Comment 8

[David Flanagan [:djf]]

I've fixed all the bugs that were blocking this one. I now believe that the word suggestions feature works well enough that we can enable it by default.  Do we have consensus that that is what we want?

Casey has said he will test the keyboard and decide on what the default behavior will be, so I'm setting the need information flag awaiting his decision.

Comment 9

[David Flanagan [:djf]]

Attachment: link to pull request that turns on suggestions by default

Dave,

I'm asking you to review this patch because it looks like you're the one who wrote the new build/settings.py script.

Dietrich: you already gave me a+ to land this in an IRC chat, but you could make it official here, if you'd like.

Comment 10

[David Flanagan [:djf]]

I just landed https://github.com/mozilla-b2g/gaia/pull/6294 to change the default setting value so that word suggestions are on by default.  The default will change when the user does make reset-gaia.  I don't know whether an over-the-air update will change it or not.

There are some new dependencies, so we're still not ready to close this metabug.

Comment 11

[David Flanagan [:djf]]

All the bugs we depend on in this metabug have been resolved, so I'm closing it.
We went ahead and made it the default while Casey was on paternity leave, so I'm cancelling the needinfo request for him.

Comment 12

[Casey Yee]

Re-opening and renoming this bug.

It seems that we are getting much better performance from the keyboard when word suggestion is turned off.  I recommend we turn this feature off by default for better keyboard usability.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Please open a different bug and let this one closed.

Comment 14

[Walter Chen[:ypwalter][:wachen]]

not the case now, but mark as verified.