797410 - Use Components.results instead of hardcoding nsresult values.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

References: FX Bug 454360 Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value.

From Bug 454360 Comment 0:

> Since bug 418406 was nice enough to expose network error constants in 
> Components.results, we really ought to make use of them rather than hardcoding 
> 0x804b0002 all over the place in JS. (Well, okay, there's one NET_TIMEOUT in 
> here, too, but it's mostly about the BINDING_ABORTED.)

From Bug 794067 Comment 2:

>> Bug 783738 Use Components.results.NS_BINDING_ABORTED instead of hardcoding
>> the value.
> Should this not cover changes to nsBrowserContentHandler.js, 
> nsBrowserStatusHandler.js and uploadProgress.js too? There is EdLinkChecker.js 
> too but that is in shared code (with TB) and is wider than just 
> NS_BINDING_ABORTED so warrants a separate bug.

Comment 1

[Philip Chee]

Useful Bugzilla query:
http://mxr.mozilla.org/comm-central/search?string=0x804B&find=%2Fsuite%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Comment 2

[Edmund Wong (:ewong)]

Attachment: Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value.

Comment 3

[Philip Chee]

> -            const kErrorBindingAborted = 0x804B0002;
>              const kErrorNetTimeout = 0x804B000E;

FYI: Components.results.NS_ERROR_NET_TIMEOUT is 0x804B000E (2152398862)

Comment 4

[Ian Neal]

Comment on attachment 668723 [details] [diff] [review]
Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value.

Would be good to get kErrorNetTimeout = 0x804B000E done too, preferably as one patch on this bug (bug title might have to be tweaked).

Comment 5

[Edmund Wong (:ewong)]

(In reply to Philip Chee from comment #3)
> > -            const kErrorBindingAborted = 0x804B0002;
> >              const kErrorNetTimeout = 0x804B000E;
> 
> FYI: Components.results.NS_ERROR_NET_TIMEOUT is 0x804B000E (2152398862)

yeah I did put that in my patch, but since it was 'offtopic' for this bug,
I removed it.   Maybe I'll tweak this bug's description to include this?

Comment 6

[[e-mail]]

I found the following constants used in suite. If you update the patch for kErrorNetTimeout then perhaps you could throw in NS_ERROR_FILE_NOT_FOUND too? I don't think the others appear in Components.results (yet).

/suite/browser/nsBrowserContentHandler.js
line 30 -- const NS_BINDING_ABORTED = 0x804b0002;
line 31 -- const NS_ERROR_WONT_HANDLE_CONTENT = 0x805d0001;

/suite/browser/nsBrowserStatusHandler.js
line 228 -- const kErrorBindingAborted = 0x804B0002;
line 229 -- const kErrorNetTimeout = 0x804B000E;

/suite/common/downloads/uploadProgress.js
line 54 -- const NS_BINDING_ABORTED = 0x804b0002;

/suite/common/sidebar/sidebarOverlay.js
line 821 -- const NS_ERROR_FILE_NOT_FOUND = 0x80520012;

/suite/common/nsContextMenu.js
line 909 -- const NS_ERROR_SAVE_LINK_AS_TIMEOUT = 0x805d0020;

/suite/feeds/src/WebContentConverter.js
line 27 -- const NS_ERROR_MODULE_DOM = 0x80530000;
line 28 -- const NS_ERROR_DOM_SYNTAX_ERR = NS_ERROR_MODULE_DOM + 12;

/suite/mailnews/mail3PaneWindowCommands.js
line 903 -- const NS_MSG_ERROR_COPY_FOLDER_ABORTED = 0x8055001a;

/suite/mailnews/messengerdnd.js
line 159 -- const NS_MSG_FOLDER_EXISTS = 0x80550013;
line 160 -- const NS_MSG_ERROR_COPY_FOLDER_ABORTED = 0x8055001a;

Comment 7

[Edmund Wong (:ewong)]

Attachment: Use Components.results instead of hardcoding nsresult values. (v2)

Comment 8

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/fd290549d8ea