797412 - Remove feeds rss.rdf file, update build config

Status: RESOLVED WONTFIX

(MailNews Core :: Account Manager, defect)

Comment 1

[alta88]

Attachment: patch

Comment 2

[alta88]

this file was effectively being used for a string, duplicated elsewhere, and one parm.  its dependence is removed by the patch in bug 796234, which must be applied first.

mark, i believe the /newsblog/jar.mn is also no longer used, please confirm; it can be added to this.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 669777 [details] [diff] [review]
patch

Review of attachment 669777 [details] [diff] [review]:
-----------------------------------------------------------------

Almost right, just need to make sure we remove the files from previous installations.

::: mailnews/extensions/newsblog/Makefile.in
@@ +18,5 @@
>  VPATH		= @srcdir@
>  
>  include $(DEPTH)/config/autoconf.mk
>  
>  MODULE		= newsblog

You can also remove this line as there's no .idl files here.

::: suite/installer/package-manifest.in
@@ -794,5 @@
>  
>  #ifdef MOZ_MOVEMAIL
>  @BINPATH@/isp/movemail.rdf
>  #endif
> -@BINPATH@/isp/rss.rdf

You need to add isp/rss.rdf to removed-files.in for both mail and suite.

Comment 4

[alta88]

Attachment: patch

updated.  what about jar.mn?

Comment 5

[Mark Banner (:standard8)]

jar.mn remains in use even though it isn't explicitly mentioned - there's a rule for it in rules.mk iirc.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 669979 [details] [diff] [review]
patch

Review of attachment 669979 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming the other bug gets r+ etc.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 669979 [details] [diff] [review]
patch

Although I'd love to see this happen, it is currently blocked by bug 796234, hence removing the outstanding review request for now, as we need that bug to progress before we can resolve this one.

Comment 8

[alta88]

due to the obstructionism in bug 796234, this is wontfix.

for Tb, however, there is no longer any reliance on feeds.rdf post bug 529131.