797680 - "Reset Assignee to default" and "Reset QA Contact to default" should only be checked when the assignee/qa-contact is the default

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[:glob ✱]

Attachment: patch v1

+++ This bug was initially created as a clone of Bug #713796 +++

1. Pick an open bug that's assigned to an actual person.
2. Select another component to move it to.
3. Look at the "Reset Assignee to default" checkbox that appears after step 2.

Result: it's checked

Expected: it should be unchecked

Comment 1

[Frédéric Buclin]

Comment on attachment 667808 [details] [diff] [review]
patch v1

>+            if (document.getElementById('qa_contact')
>+                && document.getElementById('qa_contact').value == defaults[1])

If someone cleared the QA contact, shouldn't we reset it too? In that case, the test above would become:

    if (!document.getElementById('qa_contact')
        || document.getElementById('qa_contact').value == defaults[1])


Anyway, your patch looks good and works fine. r=LpSolit in all cases.

Comment 2

[:glob ✱]

(In reply to Frédéric Buclin from comment #1)
> If someone cleared the QA contact, shouldn't we reset it too?

the qa_contact field gets the same treatment as the assignee field.
the first part of that condition looks for the existence of the field (for instances where the qa_contact field is disabled).

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified js/field.js
modified template/en/default/bug/edit.html.tmpl
Committed revision 8437.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified js/field.js
modified template/en/default/bug/edit.html.tmpl
Committed revision 8426.

Comment 3

[Frédéric Buclin]

Added to relnotes for 4.4.