Restrict the height/width of the ambient notification icons to 16x16

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

18 Branch
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17+ fixed)

Details

(Whiteboard: [Fx17])

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 667842 [details] [diff] [review]
Patch

On Windows the images of the ambient notification icons will expand to show the image at full resolution. Mac only does this on hidpi mode, and Linux handles this using max-height.

This patch should fix all three platforms to be consistent, while also allowing hidpi mode to work correctly on Mac.

Frank, can you take a look at the HiDPI change on Mac?
Attachment #667842 - Flags: review?(mixedpuppy)
Attachment #667842 - Flags: review?(fryn)

Comment 1

5 years ago
Comment on attachment 667842 [details] [diff] [review]
Patch

Review of attachment 667842 [details] [diff] [review]:
-----------------------------------------------------------------

As we discussed on IRC, the @media (min-resolution: 2dppx) block should simply be removed.
It was my mistake to add that block in the first place.
Thanks for flagging me. No need to flag me for the next version of the patch. :)
Attachment #667842 - Flags: review?(fryn)
Created attachment 668171 [details] [diff] [review]
Patch v1.1

Thanks for the feedback Frank. I removed the HiDPI block.
Attachment #667842 - Attachment is obsolete: true
Attachment #667842 - Flags: review?(mixedpuppy)
Attachment #668171 - Flags: review?(mixedpuppy)
Attachment #668171 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d24b8e3c078
tracking-firefox17: --- → ?

Updated

5 years ago
tracking-firefox17: ? → +
https://hg.mozilla.org/mozilla-central/rev/8d24b8e3c078
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #668171 - Flags: approval-mozilla-aurora+
Attachment #668171 - Flags: approval-mozilla-aurora+
Created attachment 669060 [details] [diff] [review]
aurora patch

Minus the hidpi changes.
Attachment #669060 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/95338d6f75fe
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.