Allow the dir attribute in bleach

VERIFIED FIXED

Status

developer.mozilla.org
Localization
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: teoli, Unassigned)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 667868 [details]
Screen capture of the problem

In many places we will mix ltr and rtl content, like in code snippet.

We need to be able to set the dir attributes on some structures (inside our templates) so that they appear correctly in rtl too. In Unicode some characters have an intrinsic direction, but not the < > " and other similar characters.

In https://github.com/mozilla/kuma/blob/master/apps/wiki/models.py , we should allow the CSS dir (global attribute) on all HTML elements (MathML will be in a separate bugs, once we have sorted out).

See the image showing the problem that the dir attribute will help to solve. (Though not in all cases, where we will use special Unicode characters)

Comment 1

6 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/9d3a1fd5ccd9fc9ccb8625aae9b336c7ec0aab8e
Fix bug 797779: Allow 'dir' attribute in bleach.

Since it's a global attribute in HTML, for simplicity's sake this
simply allows it on anything. If there are elements it shouldn't be
allowed on, we can always pare that down.

https://github.com/mozilla/kuma/commit/23004038c66568dee7042c700c819830601dd05a
Merge pull request #720 from ubernostrum/bleach-dir-797779

Fix bug 797779: Allow 'dir' attribute in bleach.

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
verified fixed https://developer.allizom.org/en-US/docs/HTML
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.