Closed Bug 797834 Opened 8 years ago Closed 8 years ago
build error on OSX 10
.6 in widget cocoa
On building the tip of the Alder branch I get this error below. I'm on OSX 10.6, building using clang. I do not get this error using 10.7 Users/Enda/code/mozilla/alder_default/alder/widget/cocoa/nsMacWebAppUtils.mm:49:34: error: implicit conversion of NULL constant to 'NSWorkspaceLaunchOptions' (aka 'unsigned long') [-Werror,-Wnull-conversion] options: nil ^~~ /System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:69:17: note: expanded from macro 'nil' #define nil NULL ^~~~ 1 error generated. make: *** [nsMacWebAppUtils.o] Error 1 make: *** Waiting for unfinished jobs.... make: *** [libs] Error 2 make: *** [libs_tier_platform] Error 2 make: *** [tier_platform] Error 2 make: *** [default] Error 2 make: *** [realbuild] Error 2 make: *** [build] Error 2 Replacing the nil with a 0 got me past this.
The code that triggers this error has been in the tree for a while (since http://hg.mozilla.org/mozilla-central/rev/4cffe2b37d0c landed in July), and hasn't triggered an error before now. But maybe the build infrastructure is different for branches like alder and fx-team. In any case this *is* a real error. Patch coming up shortly.
Assignee: nobody → smichaud
Attachment #668092 - Flags: review?(dwalkowski)
Comment on attachment 668092 [details] [diff] [review] Fix It's a bitfield, so yes, a zero is more correct than null. And casting it to the correct flavor is helpful documentation.
Attachment #668092 - Flags: review?(dwalkowski) → review+
Thanks Steven, Dan! http://hg.mozilla.org/integration/mozilla-inbound/rev/2849c2156345
Status: NEW → ASSIGNED
I was getting this error on m-c, too. I have no idea why it suddenly showed up. Thanks for fixing it!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.