797834 - build error on OSX 10.6 in widget cocoa

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[enda mannion (:emannion)]

On building the tip of the Alder branch I get this error below.

I'm on OSX 10.6, building using clang.  I do not get this error using 10.7

Users/Enda/code/mozilla/alder_default/alder/widget/cocoa/nsMacWebAppUtils.mm:49:34: error: implicit conversion of NULL constant to 'NSWorkspaceLaunchOptions' (aka 'unsigned long')
      [-Werror,-Wnull-conversion]
                        options: nil
                                 ^~~
/System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:69:17: note: expanded from macro 'nil'
    #define nil NULL
                ^~~~
1 error generated.
make[6]: *** [nsMacWebAppUtils.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [libs] Error 2
make[4]: *** [libs_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2 


Replacing the nil with a 0  got me past this.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

The code that triggers this error has been in the tree for a while (since http://hg.mozilla.org/mozilla-central/rev/4cffe2b37d0c landed in July), and hasn't triggered an error before now.  But maybe the build infrastructure is different for branches like alder and fx-team.

In any case this *is* a real error.  Patch coming up shortly.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix

Comment 4

[Dan Walkowski]

Comment on attachment 668092 [details] [diff] [review]
Fix

It's a bitfield, so yes, a zero is more correct than null.
And casting it to the correct flavor is helpful documentation.

Comment 5

[Anant Narayanan [:anant]]

Thanks Steven, Dan!

http://hg.mozilla.org/integration/mozilla-inbound/rev/2849c2156345

Comment 6

[Andrew McCreight [:mccr8]]

I was getting this error on m-c, too. I have no idea why it suddenly showed up. Thanks for fixing it!

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2849c2156345