797863 - update graphite2 library to release 1.2

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: update graphite2 library to release 1.2 (http://projects.palaso.org/attachments/download/298/graphite2-1.2.0.tgz)

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: fixes for minor build problems in graphite2 v1.2

A few minor fixes that tryserver tells me we need to keep our compilers happy. (Also reported upstream.)

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: change #includes of <cstdio> to <stdio.h> in graphite2 to work around bug 721839

And a hack to work around brokenness in stl_wrappers, as per bug 721839

Comment 4

[John Daggett (:jtd)]

Comment on attachment 667977 [details] [diff] [review]
fixes for minor build problems in graphite2 v1.2

Why does the GRAPHITE2_NFILEFACE need to be moved around?  Just curious...

Comment 5

[Jonathan Kew [:jfkthame]]

Because when that is defined, the entire content of the FileFace.h header is #ifdef'd out, with the result that the graphite2 namespace isn't declared. clang complains at the residual "using namespace" line when it hasn't heard of the namespace at all.

(I expect upstream didn't hit this because they don't build with GRAPHITE2_NFILEFACE.)

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ac301ef8549
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b66a5345614
https://hg.mozilla.org/integration/mozilla-inbound/rev/84e4bf4bcb87

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ac301ef8549
https://hg.mozilla.org/mozilla-central/rev/9b66a5345614
https://hg.mozilla.org/mozilla-central/rev/84e4bf4bcb87