Closed
Bug 797988
Opened 12 years ago
Closed 12 years ago
[classic] No focus rect on header field buttons in message compose
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: mnyromyr, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
|
778 bytes,
patch
|
enndeakin
:
review+
mconley
:
ui-review+
mnyromyr
:
feedback+
|
Details | Diff | Splinter Review |
|
66.42 KB,
image/gif
|
Details |
Screenshots (animated GIF)
Yeah, bug 178637 is back yet again (and for a while already, I should add). But this time, only Linux is broken, Windows/Mac look okay AFAICT. This bug is valid for the classic theme only! "Tabbing" through the header fields in the mail/news editor selects alternately a button and an input field, i.e. "Reply-To:" -> "kd-moz@tprac.de" -> "Newsgroup:" -> "de.comm.software.mozilla". With the modern theme the button gets slightly darker, but with the classic theme you can't recognize anymore where you are. 'Some months ago', there was a focus rect visible upon the currently selected button. The attached patch works for me, but feels rather awkward, tbh.
Attachment #668107 -
Flags: review?(neil)
|
Assignee | |
Comment 1•12 years ago
|
||
It looks as if I didn't copy the styles from Windows to Linux hard enough for bug 398874 - other Linux styles meant that some of them didn't take effect and others were unnecessary.
Attachment #668120 -
Flags: feedback?(mnyromyr)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 668120 [details] [diff] [review] Proposed patch Yeah, that looks definitely more useful.
Attachment #668120 -
Flags: feedback?(mnyromyr) → feedback+
|
|
Reporter | |
Updated•12 years ago
|
Attachment #668107 -
Attachment is obsolete: true
Attachment #668107 -
Flags: review?(neil)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #668120 -
Flags: ui-review?(bwinton)
|
|
Reporter | |
Updated•12 years ago
|
Assignee: mnyromyr → neil
|
||
Comment 3•12 years ago
|
||
Comment on attachment 668120 [details] [diff] [review] Proposed patch Steal!
Attachment #668120 -
Flags: ui-review?(bwinton) → ui-review?(mconley)
|
||
Comment 4•12 years ago
|
||
> Attachment #668120 [details] [diff] - Flags: ui-review?(bwinton@mozilla.com) → ui-review?(mconley@mozilla.com)
Ping mconley.|
|
||
Comment 5•12 years ago
|
||
Can somebody show me a screenshot of the header fields with, and without the patch?
|
|
Assignee | |
Comment 6•12 years ago
|
||
This is the effect on my Linux system, running Gnome 3. The focus is actually in the same place in both screen shots.
Attachment #677173 -
Flags: ui-review?(mconley)
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 668120 [details] [diff] [review] Proposed patch LGTM - thanks!
Attachment #668120 -
Flags: ui-review?(mconley) → ui-review+
|
|
||
Updated•12 years ago
|
Attachment #677173 -
Flags: ui-review?(mconley)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #668120 -
Flags: review?(gavin.sharp)
|
||
Updated•12 years ago
|
Component: MailNews: Composition → Themes
Product: SeaMonkey → Toolkit
|
|
||
Updated•12 years ago
|
Attachment #668120 -
Flags: review?(gavin.sharp) → review?(enndeakin)
|
||
Updated•12 years ago
|
Attachment #668120 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/37018544448d
|
||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/37018544448d
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•