Closed Bug 184811 Opened 22 years ago Closed 19 years ago

addressingwidget appears as sunken, not as button

Categories

(MailNews Core :: Composition, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mnyromyr, Assigned: neil)

References

Details

(Keywords: fixed1.8.0.1, fixed1.8.1)

Attachments

(6 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021210
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021210

The addressingwidget (containing a listbox for from:, to:, bcc: and the like)
does not appear like a button anymore, but as "sunken" text field with leading
drop down button.

Reproducible: Always

Steps to Reproduce:



Expected Results:  
addressingwidget should look as button with down "arrow" (as in older builds, ie
2002-11-26 and older).
This is a problem with native theming.. since this really isn't a normal 
looking menulist widget, native theming makes it look wrong.  The quick 
solution is to turn off theming using -moz-appearance: none.  Another solution 
would be to incorporate the individual parts of this control (for example, the 
down arrow by itself) into the native theme api, so the CSS for this particular 
widget could construct the appropriate look.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I can narrow this bug down to a specific build now:

ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-12-03-08-trunk/mozilla-win32-talkback.zip
 (11389 KB  03.12.2002  13:09:00) is okay, but

ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-12-04-04-trunk/mozilla-win32-talkback.zip
 (11047 KB  04.12.2002  09:58:00) does already have this problem
-->varada
Assignee: ducarroz → varada
taking all of varada's bugs.
Assignee: varada → sspitzer
Blocks: 178637
The following CSS restores the "button look" for the addressingWidget:
-------- snip ---------
/* 
 * show addressing widget in the mail editor as button (overriding native theming)
 */
.aw-menulist                        {-moz-appearance: button ! important;}
.aw-menulist > .menulist-dropmarker {-moz-appearance: none   ! important;}
-------- snip ---------

Tim: do you think it is reasonable to add this to
\mozilla\themes\classic\messenger\addressingWidget.css?
I'd provide a patch then.
Scott, check out Karsten's CSS patch in this bug -- it works for TB's default 
theme to make the address-fields appear a little nicer and also show a focus 
indication -- xref TB bug 266928, and bug 178637.
Mike, I could't tell the difference. My eyes aren't good enough.
The attached screenshot (taken from the Thunderbird 2004-10-30 branch nightly)
is valid wrt the sunken widget for both Win32 (Win2k in my case) Thunderbirds
and Mozilla MailNews with Classic skin.
With the CSS mentioned in my comment #5 put into the userChrome.css, the widget
looks much more natural (and, in fact, like it did before the changes of
comment #2).
This CSS does not work (entirely) correct for Mozilla's Modern skin: although
the widget is displayed as a button there, the button has the wrong colour.

I'd be willing to provide SM/TB patches if requested. ;-)
The screenshot posted by Karsten shows the difference that I see; to my eyes, 
it's quite a substantial one!


(In reply to comment #8)
> This CSS does not work (entirely) correct for Mozilla's Modern skin: although
> the widget is displayed as a button there, the button has the wrong colour.

But the Modern theme's default display is very similar to what's provided by 
your CSS, so there's really no need to put it there.  I was assuming, perhaps 
incorrectly, that your CSS would be patched in to the themes that need it, 
rather than systemwide.
The CSS of comment #5 isn't "the" patch. A *patch* would of course only touch
Classic and TB... 
Product: MailNews → Core
Also appears with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4)
Gecko/20050717 SeaMonkey/1.0a
OS: Windows 2000 → All
Hardware: PC → All
As discussed in bug 285288, the changes proposed in the CSS here might be 
better applied to the class  .menulist-compact  (and its dropmarker) rather 
than class  .aw-menulist  .

xref bug 301465
*** Bug 306991 has been marked as a duplicate of this bug. ***
Personally I don't like the button focus style... 
I seem to remember NS4 used a dotted outline on the text?

.menulist-compact:focus > .menulist-label {
  -moz-outline: 1px dotted invert;
}
Yeah; the widget should behave like our other buttons and show that dotted
line, too.
> Created an attachment (id=194821) [edit]
> toolbarbutton version

On Win2k, this doesn't show any focus marker on the widget, neither button nor
text border - which is bad; it should show both like our normal buttons do.
(Does the widget's height allow for the dashed text border, actually?)
Attached image outline: 1px dotted; (obsolete) —
Attached image outline: 1px dotted;
D'oh, I'd forgotton to select GIF export last time :-[
Attachment #194826 - Attachment is obsolete: true
Attachment #194845 - Flags: review?(mnyromyr)
Attachment #194845 - Flags: review?(mnyromyr)
Attachment #198322 - Flags: review?(mnyromyr)
Comment on attachment 198322 [details] [diff] [review]
Dotted for Classic, colour change for Modern

>Index: themes/modern/global/menulist.css
>===================================================================
> .menulist-compact:focus {
>-  -moz-border-radius: 0;
>+  -moz-border-radius: 0px !important;
>+  background-color: #98A5B2;
>+}
> }

One curly brace should suffice. ;-)

>Index: unix/autocomplete.css
>===================================================================
>RCS file: /cvsroot/mozilla/themes/classic/global/unix/autocomplete.css,v
>retrieving revision 1.7
>diff -u -8 -r1.7 autocomplete.css
>--- unix/autocomplete.css	17 Apr 2004 16:52:35 -0000	1.7
>+++ unix/autocomplete.css	4 Sep 2005 10:52:14 -0000

Real programmers create their patches manually, don't they? *g*


I'm so glad that this issue will be fixed finally! :-D
Attachment #198322 - Flags: review?(mnyromyr) → review+
Attachment #198322 - Flags: superreview?(jag)
Attachment #198322 - Flags: superreview?(jag) → superreview+
Comment on attachment 198322 [details] [diff] [review]
Dotted for Classic, colour change for Modern

Low risk, SM only, very visible theme fix.
Attachment #198322 - Flags: approval1.8rc1?
Comment on attachment 198322 [details] [diff] [review]
Dotted for Classic, colour change for Modern

approving seamonkey only change
Attachment #198322 - Flags: approval1.8rc1? → approval1.8rc1+
Attached patch Better patch (obsolete) — Splinter Review
This avoids unnecessary xbl changes that might break other themes e.g. Mac ;-)
Assignee: sspitzer → neil.parkwaycc.co.uk
Attachment #198322 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #200265 - Flags: superreview?(jag)
Attachment #200265 - Flags: review?(mnyromyr)
+.menulist-compact > .menulist-label-box > .menulist-label {
+.menulist-compact > .menulist-label-box > .menulist-icon {
+.menulist-compact:focus > .menulist-label-box {

You removed the xbl change, right?
Re: attachment 200265 [details] [diff] [review]:
Just a nit: With this patch, the dropdownbox is rather small (exactly the same width as the widget's "fake button" itself), thus it even crops headers like "Followup-To:", although enough space is available...
(Win2k, Classic, see attached screenshot.)
r=me with that fixed.
Attachment #200265 - Flags: review?(mnyromyr) → review+
*** Bug 313734 has been marked as a duplicate of this bug. ***
Thanks for spotting that nit - it wasn't a simple tweak so rerequesting review.
Attachment #200265 - Attachment is obsolete: true
Attachment #200984 - Flags: superreview?(jag)
Attachment #200984 - Flags: review?(mnyromyr)
Attachment #200265 - Flags: superreview?(jag)
Attachment #200984 - Flags: review?(mnyromyr) → review+
Attachment #200984 - Flags: superreview?(jag) → superreview+
It looks like the autocomplete.css change fixes something unrelated. sr=jag for that too.
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Seamonkey 1.1a-1031, Win2K: this looks great, Modern and Classic!
Thanks, Neil!
*** Bug 318475 has been marked as a duplicate of this bug. ***
*** Bug 322278 has been marked as a duplicate of this bug. ***
Comment on attachment 200984 [details] [diff] [review]
Addressed review comment

a=me for SM1.0 and SM1.1 for SM only patch, need one more for SM1.0
a=me for SeaMonkey 1.0
Fix checked in to the branches with a=CTho given over IRC.
Product: Core → MailNews Core
Blocks: 797988
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: