Closed Bug 798020 Opened 8 years ago Closed 8 years ago
Assertion failure: "Computed width should always be constrained, so horizontal flex containers should always have a constrained main-size"
With user_pref("layout.css.flexbox.enabled", true); the testcase triggers: Assertion failure: !IsAxisHorizontal(aAxisTracker.GetMainAxis()) (Computed width should always be constrained, so horizontal flex containers should always have a constrained main-size), at layout/generic/nsFlexContainerFrame.cpp:1794
Comment on attachment 668142 [details] testcase (asserts fatally when loaded) ><body style="letter-spacing: 693626589697em;"> Oh, Jesse. :) So this looks like a case where our actual computed width is large enough to overflow NS_UNCONSTRAINEDSIZE, so it looks like we've got an unconstrained computed-width, and we're not expecting that. We should probably just change this to a NS_WARNING instead of a MOZ_ASSERT, since web content can trigger this (with ridiculously huge values) and it's not a problem, it'll just give incorrect layout. (we'll shrinkwrap instead of honoring the gigantic height)
Sounds reasonable. If we ever do bug 765861, we can turn it into a conditional assert.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #668826 - Flags: review?(dbaron)
Comment on attachment 668826 [details] [diff] [review] fix r=dbaron
Attachment #668826 - Flags: review?(dbaron) → review+
(unprefixed testcase code before pushing, per bug 801098)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.