Unprefix CSS3 flexbox

RESOLVED FIXED in mozilla19

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla19
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox -)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Just talked to dbaron, and we agree that while the last flexbox implementation issues are being hashed out, it's fine to have it unprefixed, as long as it's still preffed off by default.

So: filing this bug on unprefixing all the CSS3 flexbox properties/keywords.

Updated

5 years ago
Blocks: 775235
Created attachment 671043 [details] [diff] [review]
(wrong patch file, ignore)

I'm splitting this into 3 parts:
 - changes in code
 - changes in mochitests
 - changes in reftests/crashtests
...though I'll fold the three together when landing, because they need to all land together to keep from breaking tests.
Attachment #671043 - Flags: review?(dbaron)
Created attachment 671044 [details] [diff] [review]
part 1: unprefix in code

(oops, here's the right patch)
Attachment #671043 - Attachment is obsolete: true
Attachment #671043 - Flags: review?(dbaron)
Attachment #671044 - Flags: review?(dbaron)
Attachment #671043 - Attachment description: part 1: unprefix in code → (wrong patch file, ignore)
Created attachment 671045 [details] [diff] [review]
part 2: unprefix in mochitests

(This also unprefixes some -moz-calc and -moz-keyframes usages -- those are there because I originally wrote those test files before we unprefixed those keywords, and landed them after we unprefixed)
Attachment #671045 - Flags: review?(dbaron)
Created attachment 671046 [details] [diff] [review]
part 3: unprefix in reftests/crashtests

Note: the first chunk of this patch fixes up the crashtest for bug 737313, which was added back when "-moz-flexbox" was the display keyword.

This patch replaces that with "display: flex", and also adds the pref() annotation to it in the crashtest manifest while I'm at it.
Attachment #671046 - Flags: review?(dbaron)
Try run w/ just these patches:
   https://tbpl.mozilla.org/?tree=Try&rev=514f0370ce25
Try run w/ these patches, plus a patch to enable the flexbox pref by default (which enables a few more tests):
  https://tbpl.mozilla.org/?tree=Try&rev=e78ce92b3c73
(In reply to Daniel Holbert [:dholbert] from comment #5)
> Try run w/ these patches, plus a patch to enable the flexbox pref by default
> (which enables a few more tests):
>   https://tbpl.mozilla.org/?tree=Try&rev=e78ce92b3c73

That one had some orange due to mochitests/reftests expectation about the pref being disabled. Changed those expectations and pushed again, for a greener Try run:
  https://tbpl.mozilla.org/?tree=Try&rev=576bb4e670ff
Comment on attachment 671044 [details] [diff] [review]
part 1: unprefix in code

r=dbaron, but I hope these nsIDOMCSS2Properties.idl changes aren't detectable thanks to our use of the new bindings.  (Can we remove that file yet?!)
Attachment #671044 - Flags: review?(dbaron) → review+
Attachment #671045 - Flags: review?(dbaron) → review+
Comment on attachment 671046 [details] [diff] [review]
part 3: unprefix in reftests/crashtests

Interesting that a few tests had -moz-flexbox instead of -moz-flex.
Attachment #671046 - Flags: review?(dbaron) → review+
(In reply to David Baron [:dbaron] from comment #8)
> Interesting that a few tests had -moz-flexbox instead of -moz-flex.

Yeah, just a couple crashtests added back when that was the keyword. (see first chunk of comment 4.)

Thanks for the review!
(In reply to David Baron [:dbaron] from comment #7)
> r=dbaron, but I hope these nsIDOMCSS2Properties.idl changes aren't
> detectable thanks to our use of the new bindings.  (Can we remove that file
> yet?!)

I think we're still using that file for something, but I don't remember what.  (I think bz knows, though...)

I realized that I forgot to rev the UUID of that interface, though (for the benefit of whatever straggling code still uses that file :)  )  I fixed that locally, folded the patches together per comment 1, and pushed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/8a070a22c369
> I think we're still using that file for something, but I don't remember what.

We only use it if the CSSDeclaration binding is preffed off.

I'll work on removing that pref and that IDL file.  Bug 801819.
Would this land by Friday? I am supposed to lead the effort to write css3-flex tests in this weekends' Test the Web Forward @ Beijing and it would of course be nice to reduce as much trouble as we can. :)
Thanks Kenny -- I actually just landed it on inbound, in comment 10!  If all goes well, it should be merged to mozilla-central within the next day or so.
(In reply to Daniel Holbert [:dholbert] from comment #13)
> Thanks Kenny 

*We* should all thank you :)

> -- I actually just landed it on inbound, in comment 10!  If all
> goes well, it should be merged to mozilla-central within the next day or so.

Congrats!
https://hg.mozilla.org/mozilla-central/rev/8a070a22c369
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Keywords: dev-doc-needed
Documented (without speaking about the prefix): https://bugzilla.mozilla.org/show_bug.cgi?id=666041#c132
Keywords: dev-doc-needed → dev-doc-complete
This might be worth mentioning in a release note for Firefox 19.

(This feature is preffed-off, just like it was in Firefox 18 -- but for users who've manually preffed it on, the css3 flexbox CSS properties / keywords no longer use a vendor-prefix.)
relnote-firefox: --- → ?
(In reply to Daniel Holbert [:dholbert] from comment #17)
> This might be worth mentioning in a release note for Firefox 19.
> 
> (This feature is preffed-off, just like it was in Firefox 18 -- but for
> users who've manually preffed it on, the css3 flexbox CSS properties /
> keywords no longer use a vendor-prefix.)

We haven't relnote'd disabled features in the past.
relnote-firefox: ? → -
You need to log in before you can comment on or make changes to this bug.