aboutSocialError.xhtml doesn't include Social.jsm with the right url

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

18 Branch
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 668496 [details] [diff] [review]
Fix Social.jsm url in aboutSocialError.xhtml
Attachment #668496 - Flags: review?(gavin.sharp)
Version: 14 Branch → 18 Branch
Attachment #668496 - Flags: review?(gavin.sharp) → review?(felipc)
Attachment #668496 - Flags: review?(felipc) → review+
I'll roll up this change together with the patches from bug 766616 when uplifiting it to aurora

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4bb09009a54
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9678df7672 because something in the push was hitting "browser_frameworker.js | sub-test testEarlyClose failed: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.nukeSandbox]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/FrameWorker.jsm :: terminate :: line 239" data: no]" and "browser_frameworker.js | check that websockets worked - Got FAILED calling WebSocket constructor: TypeError: WebSocket is not a constructor, expected ok" and I didn't know which (though I presume bug 790201), and didn't know interconnectedness among them.
relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/43f7b44fcf15

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/43f7b44fcf15
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
fixed in aurora with cset https://hg.mozilla.org/releases/mozilla-aurora/rev/b69ca3697450
status-firefox17: --- → fixed
Flagging [qa-] as I don't think this needs QA verification. Please correct me if I am wrong.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.